159 - Manage File User Permissions for the Files Tab

[MellyGray]

What this PR does / why we need it:

This PR adds the management of the file user permissions for the the Files Tab.

Which issue(s) this PR closes:

• Closes [Spike - Frontend] Manage user permissions for the conditional rendering #159

Special notes for your reviewer:

Changes

1. Two new useCases added to manage the file permissions checkFileDownloadPermission and checkFileEditDatasetPermission. Note: The checkFileEditDatasetPermission at the file level may be replaced in the future by a checkDatasetEditPermission at the dataset level but since in the js-dataverse implementation the editDataset permission can only be retrieved using a file, that's what have been implemented in the UI.
2. The File model has been refactored to remove the canDowload property since this property is actually a permission instead of a property of the resource. This affects most of the changed code
3. A FilePermissionsProvider has been added to globally manage the file permissions in the application

Suggestions on how to test this:

To test this from a UI perspective, the Files Tab elements in the Storybook should continue being displayed as in the previous PRs, this is because in previous PRs the permissions were hardcoded and now they have been implemented with their own use cases. So basically the testing consists on checking that everything is being displayed in the Files Table as it was before, for example as it was working in the feature/139-files-table-file-action-buttons-ui branch

1. npm i
2. cd packages/design-system && npm run build
3. cd ../../
4. npm run storybook
5. Check the Dataset Page and the stories in Sections/Dataset Page/DatasetFiles/

Is there a release notes update needed for this change?:

No

Additional documentation:

[coveralls]

Changes unknown when pulling abbf383 on feature/159-manage-user-permissions-files into ** on feature/139-files-table-file-action-buttons-ui**.

[pdurbin]

I'm approving this. I didn't do any particular testing apart from getting the section to load in story book.

I looked through the diff of just this PR (which merges into non-develop) at feature/139-files-table-file-action-buttons-ui...feature/159-manage-user-permissions-files

I forget if I asked this already, but I still wonder why it's called DatasetMother. I wonder if it should be DatasetParent instead.

Also, it's weird to me that there are 200 total files in Storybook and somehow within that small number there are 100K embargoed files. 😄

[kcondon]

@MellyGray I actually had trouble loading this in Storybook. I saw two blank pages:

[GPortas]

@pdurbin For any class you see with the "Mother" suffix, it is a naming convention for classes used in testing that create objects that we use for tests.

https://martinfowler.com/bliki/ObjectMother.html

[MellyGray]

@MellyGray I actually had trouble loading this in Storybook. I saw two blank pages:

@kcondon mmm, I tried with the above steps and it's working for me.

Sometimes I fix the blank page in Storybook by deleting the node_modules cache, from the dataverse-frontend/ root run:

rm -rf node_modules/.cache && npm i

If that doesn't work then maybe try deleting the whole node_modules folder:

rm -rf node_modules && npm i

Also sometimes it takes a while for storybook to load the pages, so try waiting for sometime to see if the console prints something else such as another error or [vite] connecting

If none of the above works, we can try troubleshooting in a zoom call because I've never seen that error message in the console. I'd say it's something about the dependencies but no idea.

[kcondon]

@MellyGray I keep seeing blank pages, even after trying the tricks:

Sometimes I fix the blank page in Storybook by deleting the node_modules cache, from the dataverse-frontend/ root run:

rm -rf node_modules/.cache && npm i

If that doesn't work then maybe try deleting the whole node_modules folder:

rm -rf node_modules && npm i

[MellyGray]

@kcondon We can try troubleshooting in a zoom call after the standup

[kcondon]

@MellyGray Yes, maybe try after standup, thanks!

[kcondon]

@MellyGray Works well but the changed behavior of the checkbox selecting all on a page rather than all isn't in this -still selects all files.

[MellyGray]

Works well but the changed behavior of the checkbox selecting all on a page rather than all isn't in this -still selects all files.

@kcondon I've merged the changes from 'develop' into this branch, so now the checkbox should work as expected here as well