134 - Files table UI [1/2] - Integration display data

[MellyGray]

What this PR does / why we need it:

This PR adds the integration of the js-dataverse use cases to get the files into the SPA UI

Which issue(s) this PR closes:

• Closes [Spike - Integration] [1/2] Create the File Tab of the Dataset page - Display data #134

Special notes for your reviewer:

Changes

1. js-dataverse getDatasetFiles added to the FileRepository js-dataverse implementation
2. js-dataverse getFileUserPermissions added to the FileRepository js-dataverse implementation
3. js-dataverse getFileDownloadCount added to the FileRepository js-dataverse implementation
4. Multiple fixes in the Files Tab logic derived from the integration
5. Integration tests for the FileJSDataverseRepository added
6. e2e tests to check the correctly display of the Files Tab added

Notes

The total files count is not yet integrated into the js-dataverse module so the number is still mocked

• [Spike - Integration] Add actual file counts to the files tab UI #168

Also, the e2e tests are failing in the Github Action because the dataverse branch haven't been merged yet. But they should work locally npm run test:e2e

Suggestions on how to test this:

Step 1: Run the development environment

1. Run npm I
2. cd packages/design-system && npm run build
3. cd ../../
4. Check that you have a .env file such as the .env.example, with the VITE_DATAVERSE_BACKEND_URL=http://localhost:8000 variable
5. cd dev-env
6. ./run-env.sh 9692-files-api-extension-display-data
7. To check the environment go to http://localhost:8000 and check your local dataverse installation

Step 2: Test Dataset View mode with the implemented changes for the getDatasetFiles

1. Go to http://localhost:8000
2. Login as admin using username: dataverseAdmin and password: admin1
3. Create a new Dataset
4. Upload some files
5. From the dataset view mode copy the search parameters from the url. Ex.: ?persistentId=doi:10.5072/FK2/LHGRHP&version=DRAFT
6. Go to http://localhost:8000/spa/datasets and paste the search parameters. Ex.: http://localhost:8000/spa/datasets?persistentId=doi:10.5072/FK2/LHGRHP&version=DRAFT
7. You are seeing now the same Dataset in the SPA, check that all the data is displayed correctly regarding the Files Tab. Note that some api calls are still mocked such as the number of files and the filters, only the display of the files data and the Sort button should work.

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

No

Is there a release notes update needed for this change?:

Files Tab data display integrated with the backend

Additional documentation:

[MellyGray]

I have left some comments in the code and below I share some functionality details to fix.

SPA:

Thanks for your detailed review! I applied most of the changes, just one thing to discuss:

Regarding point 1 of your screenshot. I see 2 options to fix it:

1. In JSF this property is read directly from dataFile as fileMetadata.dataFile.friendlyType, should js-dataverse module retrieve this friendlyType property?
2. If we think this is a frontend responsibility then I can upload the mapping file from JSF to the SPA to perform this mapping directly in the SPA. But then the rest of frontends using the API won't have access to this mapping.

Let me know which approach do you prefer

[GPortas]

@MellyGray

Let's add the friendlyType property, both to the js-dataverse model and to the associated file API payload. Since, as you say, it may be useful for other applications and is also straightforward to add. You can keep it as it is for now, make note of this change and implement it once we have implemented it in js-dataverse/API.

I have run the application again to test the latest changes. I have only found a small detail to correct.

JSF:

SPA:

You can see how there is a space missing between MD5: and the value in the SPA version.

MD5:f56...22b

But it should be like

MD5: f56...22b

[GPortas]

There are some conflicts in this PR to be resolved.

[MellyGray]

@GPortas I fixed the MD5: f56...22b and the merge conflicts!

[GPortas]

LGTM!

[kcondon]

@GPortas @MellyGray I think embargo is not enabled in the container so can't configure and check but looks good, merging.