added a dependency so that dev_solr waits for dev_solr_initializer to… #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A number of automated checks are failing (chromatic, e2e, and component) but I'm not sure if that's expected or not. We should check with @GPortas and @MellyGray I did get on this branch and try the run-env script. Dataverse spun up fine and I was able to create a collection with no Solr error. Moving to QA. I'm going to slap a size of 10 on this for the combined hours spent. |
pdurbin
approved these changes
Sep 22, 2023
There was a problem hiding this comment.
Works on my machine!
By the way, here are the depends_on docs @poikilotherm linked us to: https://github.com/compose-spec/compose-spec/blob/master/spec.md#long-syntax-1 (thanks!)
Sending to QA but note that some automated tests are failing. I'm not sure why. 🤔
jayanthkomarraju
pushed a commit
to jayanthkomarraju/dataverse-frontend
that referenced
this pull request
May 31, 2024
added a dependency so that dev_solr waits for dev_solr_initializer to…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… complete
What this PR does / why we need it:
modifies docker-compose so that dev_solr service waits for dev_solr_initializer to complete
Which issue(s) this PR closes:
Special notes for your reviewer:
Suggestions on how to test this:
Call ./run-env.sh to start the dataverse container.
Go to dataverse (localhost:8000) and login as dataverseAdmin.
Try to create a dataverse. It should create the dataverse successfully.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
No
Is there a release notes update needed for this change?:
Additional documentation: