129 - Dataset Action Buttons UI

[MellyGray]

What this PR does / why we need it:

This PR adds the Dataset Action Buttons UI to the Dataset Page View Mode

Which issue(s) this PR closes:

• Closes [Spike - Frontend] UI of the Dataset page action buttons #129

Special notes for your reviewer:

Some dataset properties are not connected to js-dataverse yet, so take that into account that if you test the e2e. For example the LinkDatasetButton is always going to appear in the e2e page, but if you look at the unit tests the LinkDatasetButton will only appear if the Dataset is released.

Changes in this PR

1. Dataset Action Buttons added to the UI
2. New properties added to the Dataset model
3. DatasetProvider added to get the dataset from any component in the Dataset Page
4. Files components refactored to read the new Dataset properties

Suggestions on how to test this:

To test the changes introduced by this PR, follow these steps:

1. Install the necessary dependencies using npm install.
2. Build the design system with cd packages/design-system && npm run build.
3. Navigate back to the root directory with cd ../../.
4. Start Storybook with npm run storybook.
5. Visit the Dataset Action Buttons section in the Storybook

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

Is there a release notes update needed for this change?:

Dataset Action Buttons added to the Dataset Page

Additional documentation:

[coveralls]

coverage: 98.394% (+0.5%) from 97.897% when pulling 3bad83e on feature/129-dataset-page-action-buttons into 6d8ecd8 on develop.

[GPortas]

Looks good!

It seems that the top of the citation block is not aligned with the top of the buttons. Can we fix this?

[GPortas]

So to create an instance of a dataset model, you will also need to obtain the permissions that the current user has on the particular dataset. I'm not sure if coupling these permissions within the dataset model can be problematic.

[MellyGray]

Exactly like that, in order to create the Dataset you'll need the user permissions.

I understand your concern and these are the reasons to have them together:

1. The dataset permissions are always used with the dataset model. So I think these permissions belong to the Dataset model, for keeping the cohesion
2. If we have another page where we want to use the dataset permissions without the model. We can do it, getDatasetPermissions and you return the DatasetPermissions interface. But this is not going to happen in the Dataset Page, in the dataset page we always want the dataset and the dataset permissions, so it makes sense to have them together.
3. I separated the File Permissions from the File model and it's being a nightmare, you need to remember to call these permissions when you get the files, initialise the React context, wait for them to be fetched, the tests are much more complex. Too much complexity for the aim of keeping the separation of concerns, when in reality I never use the file permissions without the files itself. I want to refactor that but I was also waiting for some feedback on this other approach.

I think the Dataset model is in reality the DatasetPage model, so its aim is to represent a DatasetPage, and the dataset page doesn't make sense without the permissions.

Very interesting conversation, please let me know if you can think of some problems of this approach

[MellyGray]

@GPortas I applied the requested changes

1. Show action buttons on the Default page of the storybook. Only the Access Dataset one because it's more realistic
2. Align the top of the buttons with the citation block
3. Fix the publication disabled on the Draft with all Dataset Permissions story

[GPortas]

LGTM!