-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/127 add alert messages to dataset view #194
Feature/127 add alert messages to dataset view #194
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The component looks good but there are some behaviours that are different from JSF, take a look at my comments
Hi @MellyGray , welcome back from vacation! Also, while testing on Demo dataverse, I noticed use case I hadn't seen before, 'Incomplete Metadata': I'm not sure how the dataset got into that state - some required fields were missing. I think it may have gotten into a bad state when the Demo dataverse was updated - maybe a new metadata block was added? But since the JSF has an alert for it, I think we need to add it (maybe in a subsequent ticket). The style of it, with red text in a warning box, doesn't match our existing Alert component, so we should probably talk to the team about modifying it for the SPA. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Let's move this forward
…ation is completed)
I fixed the logic for determining if the dataset has been published (this is temporary, and will be replaced with info from the server when integration is completed). |
…to-dataset-view Feature/127 add alert messages to dataset view
What this PR does / why we need it:
Adds Alert messages to Dataset View Page (for draft version, unpublished version, and version not found)
Which issue(s) this PR closes:
Special notes for your reviewer:
Suggestions on how to test this:
View the alert messages in Storybook, in the DatasetAlerts section. In the local dev environment, go to Dataverse and create the 3 scenarios (draft version, unpublished version, and version not found), then view the dataset page in the SPA.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
no
Is there a release notes update needed for this change?:
no
Additional documentation: