-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
130 - Dataset citation thumbnail #202
Conversation
Shouldn't a thumbnail image be displayed instead of the default image? @MellyGray I'm on http://localhost:6006/?path=/story/sections-dataset-page-datasetcitation--with-thumbnail |
…github.com/IQSS/dataverse-frontend into feature/130-dataset-citation-thumbnail
@GPortas sorry, that was a last minute change and I mixed things 🙏 fixed now! I also fixed some merge conflicts |
@MellyGray Can you please resolve the conflicts? Thanks! |
It seems that we have another issue when building the app for beta testing: https://github.com/IQSS/dataverse-frontend/actions/runs/6732893099/job/18300451474 Can you fix it so we can stabilize develop as you did on the other PR? Do you know how we can detect this before merging PRs? @MellyGray |
…into feature/130-dataset-citation-thumbnail
@GPortas I fixed the merge conflicts Also, both the storybook error and this one was caused by type errors so I added a new step to the Github action and to the precommit to check this type of errors |
…umbnail 130 - Dataset citation thumbnail
What this PR does / why we need it:
This PR adds the dataset thumbnail logic to the UI. This is not yet connected to the API
Which issue(s) this PR closes:
Special notes for your reviewer:
This is not yet connected to the API, it will need an API extension to get the dataset thumbnail.
Suggestions on how to test this:
npm install
.cd packages/design-system && npm run build
.cd ../../
.npm run storybook
.Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Yes, this PR introduces a user interface change.
Is there a release notes update needed for this change?:
Dataset thumbnail added to the Dataset View Mode