Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

130 - Dataset citation thumbnail #202

Merged
merged 6 commits into from
Nov 3, 2023

Conversation

MellyGray
Copy link
Contributor

@MellyGray MellyGray commented Oct 24, 2023

What this PR does / why we need it:

This PR adds the dataset thumbnail logic to the UI. This is not yet connected to the API

Which issue(s) this PR closes:

Special notes for your reviewer:

This is not yet connected to the API, it will need an API extension to get the dataset thumbnail.

Suggestions on how to test this:

  1. Install the necessary dependencies using npm install.
  2. Build the design system with cd packages/design-system && npm run build.
  3. Navigate back to the root directory with cd ../../.
  4. Start Storybook with npm run storybook.
  5. Visit the Dataset Citation section in the Storybook a new story has been added to show how the thumbnail image will be displayed in the Citation block.

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

Yes, this PR introduces a user interface change.

dataset_thumbnail

Is there a release notes update needed for this change?:

Dataset thumbnail added to the Dataset View Mode

@coveralls
Copy link

coveralls commented Oct 24, 2023

Coverage Status

coverage: 98.298% (-0.3%) from 98.58% when pulling 462ac44 on feature/130-dataset-citation-thumbnail into 97695ea on develop.

@MellyGray MellyGray marked this pull request as ready for review October 24, 2023 10:40
@MellyGray MellyGray added the Size: 3 A percentage of a sprint. 2.1 hours. label Oct 24, 2023
@GPortas GPortas self-assigned this Oct 27, 2023
@GPortas
Copy link
Contributor

GPortas commented Oct 27, 2023

Shouldn't a thumbnail image be displayed instead of the default image? @MellyGray

I'm on http://localhost:6006/?path=/story/sections-dataset-page-datasetcitation--with-thumbnail

storybookthumbnail

@MellyGray MellyGray removed their assignment Oct 27, 2023
@MellyGray
Copy link
Contributor Author

@GPortas sorry, that was a last minute change and I mixed things 🙏 fixed now! I also fixed some merge conflicts

@GPortas GPortas removed their assignment Oct 30, 2023
Base automatically changed from feature/160-display-actual-file-thumbnails to develop November 2, 2023 10:11
@MellyGray MellyGray linked an issue Nov 2, 2023 that may be closed by this pull request
@GPortas
Copy link
Contributor

GPortas commented Nov 2, 2023

@MellyGray Can you please resolve the conflicts? Thanks!

@GPortas
Copy link
Contributor

GPortas commented Nov 2, 2023

It seems that we have another issue when building the app for beta testing: https://github.com/IQSS/dataverse-frontend/actions/runs/6732893099/job/18300451474

Can you fix it so we can stabilize develop as you did on the other PR?

Do you know how we can detect this before merging PRs? @MellyGray

@MellyGray
Copy link
Contributor Author

@GPortas I fixed the merge conflicts

Also, both the storybook error and this one was caused by type errors so I added a new step to the Github action and to the precommit to check this type of errors

@MellyGray MellyGray removed their assignment Nov 2, 2023
@GPortas GPortas merged commit 3bb4f17 into develop Nov 3, 2023
5 of 6 checks passed
@GPortas GPortas deleted the feature/130-dataset-citation-thumbnail branch November 3, 2023 08:37
jayanthkomarraju pushed a commit to jayanthkomarraju/dataverse-frontend that referenced this pull request May 31, 2024
…umbnail

130 - Dataset citation thumbnail
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Size: 3 A percentage of a sprint. 2.1 hours.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Spike - Frontend] Implement Dataset citation thumbnail
3 participants