Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

200 - Integration total dataset files size with search criteria #204

Conversation

MellyGray
Copy link
Contributor

What this PR does / why we need it:

This PR adds the FileCriteria to the getFilesTotalDownloadSize use case, so the files total download size takes into account the filters and search applied to get the files.

Which issue(s) this PR closes:

Special notes for your reviewer:

Suggestions on how to test this:

Step 1: Run the development environment

  1. Run npm I
  2. cd packages/design-system && npm run build
  3. cd ../../
  4. Check that you have a .env file such as the .env.example, with the VITE_DATAVERSE_BACKEND_URL=http://localhost:8000 variable
  5. cd dev-env
  6. ./run-env.sh unstable
  7. To check the environment go to http://localhost:8000 and check your local dataverse installation

Step 2: Test Dataset View mode with the implemented changes for the getFilesTotalDownloadSize

  1. Go to http://localhost:8000
  2. Login as admin using username: dataverseAdmin and password: admin1
  3. Create a new Dataset
  4. Upload more than 10 files so the Files Table has pagination, I suggest 30 files or so, files with different types, or tags, or access.
  5. From the dataset view mode copy the search parameters from the url. Ex.: ?persistentId=doi:10.5072/FK2/LHGRHP&version=DRAFT
  6. Go to http://localhost:8000/spa/datasets and paste the search parameters. Ex.: http://localhost:8000/spa/datasets?persistentId=doi:10.5072/FK2/LHGRHP&version=DRAFT
  7. You are seeing now the same Dataset in the SPA, now apply some filter to the Files Table. Click the table header checkbox to select the whole page, click Select All and check that the total size of the select files is correct. Now apply some filters and do the same, check that the total size of the select files is correct when applying some filters

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

No

Is there a release notes update needed for this change?:

No

Additional documentation:

@MellyGray MellyGray marked this pull request as ready for review October 25, 2023 08:48
@MellyGray MellyGray added the Size: 3 A percentage of a sprint. 2.1 hours. label Oct 25, 2023
@coveralls
Copy link

coveralls commented Oct 25, 2023

Coverage Status

coverage: 98.302% (-0.3%) from 98.58% when pulling df407d8 on feature/200-integration-total-dataset-files-size-with-search-criteria into 1212e31 on develop.

@GPortas GPortas self-assigned this Oct 31, 2023
Copy link
Contributor

@GPortas GPortas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

sizes.mov

@GPortas GPortas removed their assignment Oct 31, 2023
Base automatically changed from feature/172-integration-add-filecriteria-to-the-getfilescountinfo-use-case to develop November 2, 2023 12:36
@GPortas
Copy link
Contributor

GPortas commented Nov 2, 2023

@MellyGray Can you please resolve the conflicts? Thanks!

…into feature/200-integration-total-dataset-files-size-with-search-criteria
@MellyGray MellyGray removed their assignment Nov 2, 2023
@GPortas GPortas merged commit 563f95d into develop Nov 3, 2023
5 of 6 checks passed
@GPortas GPortas deleted the feature/200-integration-total-dataset-files-size-with-search-criteria branch November 3, 2023 08:41
jayanthkomarraju pushed a commit to jayanthkomarraju/dataverse-frontend that referenced this pull request May 31, 2024
…ataset-files-size-with-search-criteria

200 - Integration total dataset files size with search criteria
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Size: 3 A percentage of a sprint. 2.1 hours.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integration - Modify get total dataset files size to accept File Criteria
3 participants