-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
200 - Integration total dataset files size with search criteria #204
Merged
GPortas
merged 8 commits into
develop
from
feature/200-integration-total-dataset-files-size-with-search-criteria
Nov 3, 2023
Merged
200 - Integration total dataset files size with search criteria #204
GPortas
merged 8 commits into
develop
from
feature/200-integration-total-dataset-files-size-with-search-criteria
Nov 3, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…earch-criteria' of https://github.com/IQSS/dataverse-frontend into feature/200-integration-total-dataset-files-size-with-search-criteria
GPortas
approved these changes
Oct 31, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
sizes.mov
Base automatically changed from
feature/172-integration-add-filecriteria-to-the-getfilescountinfo-use-case
to
develop
November 2, 2023 12:36
@MellyGray Can you please resolve the conflicts? Thanks! |
…into feature/200-integration-total-dataset-files-size-with-search-criteria
GPortas
deleted the
feature/200-integration-total-dataset-files-size-with-search-criteria
branch
November 3, 2023 08:41
jayanthkomarraju
pushed a commit
to jayanthkomarraju/dataverse-frontend
that referenced
this pull request
May 31, 2024
…ataset-files-size-with-search-criteria 200 - Integration total dataset files size with search criteria
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds the FileCriteria to the getFilesTotalDownloadSize use case, so the files total download size takes into account the filters and search applied to get the files.
Which issue(s) this PR closes:
Special notes for your reviewer:
Suggestions on how to test this:
Step 1: Run the development environment
npm I
cd packages/design-system && npm run build
cd ../../
.env
file such as the .env.example, with theVITE_DATAVERSE_BACKEND_URL=http://localhost:8000
variablecd dev-env
./run-env.sh unstable
Step 2: Test Dataset View mode with the implemented changes for the getFilesTotalDownloadSize
?persistentId=doi:10.5072/FK2/LHGRHP&version=DRAFT
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
No
Is there a release notes update needed for this change?:
No
Additional documentation: