Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

187 - Files table download button #209

Merged
merged 6 commits into from
Nov 2, 2023

Conversation

MellyGray
Copy link
Contributor

What this PR does / why we need it:

This PR add the Download Button to the Files Table. (Only the UI with no backend integration yet)

Which issue(s) this PR closes:

Special notes for your reviewer:

Suggestions on how to test this:

  1. Install the necessary dependencies using npm install.
  2. Build the design system with cd packages/design-system && npm run build.
  3. Navigate back to the root directory with cd ../../.
  4. Start Storybook with npm run storybook.
  5. Visit the Dataset in the Storybook to check that the Download button is being displayed in the Files Table, also check the behaviour about showing the No Selected Files Modal if no files are being selected

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

Mockup of the requested element

Captura de pantalla 2023-10-02 a las 11 11 10

For tabular data this is a dropdown

Screen Shot 2023-10-05 at 2 49 22 PM

Is there a release notes update needed for this change?:

Download button added to the Files Table UI

Additional documentation:

@MellyGray MellyGray marked this pull request as ready for review October 26, 2023 14:54
@MellyGray MellyGray added the Size: 3 A percentage of a sprint. 2.1 hours. label Oct 26, 2023
@coveralls
Copy link

coveralls commented Oct 26, 2023

Coverage Status

coverage: 98.286% (-0.08%) from 98.367% when pulling 9675c50 on feature/187-files-table-download-button into ac5c109 on develop.

Base automatically changed from feature/170-integration-files-download-size to develop October 26, 2023 23:07
@ekraffmiller ekraffmiller self-assigned this Oct 30, 2023
@MellyGray MellyGray linked an issue Oct 30, 2023 that may be closed by this pull request
Copy link
Contributor

@ekraffmiller ekraffmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Melina, this looks good, my only comment is do we need to add this button to the DatasetFiles-Default story?
JSF UI
Screenshot 2023-10-30 at 3 55 22 PM
DatasetFiles story
Screenshot 2023-10-30 at 3 55 04 PM

@MellyGray
Copy link
Contributor Author

@ekraffmiller Now the default story should display de download button, thx!

@MellyGray MellyGray removed their assignment Oct 31, 2023
Copy link
Contributor

@ekraffmiller ekraffmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@GPortas GPortas self-assigned this Nov 2, 2023
@GPortas GPortas removed their assignment Nov 2, 2023
@GPortas GPortas assigned GPortas and unassigned ekraffmiller Nov 2, 2023
@GPortas
Copy link
Contributor

GPortas commented Nov 2, 2023

Works good on Storybook!

downloadbutton

Merging

@GPortas GPortas merged commit 97695ea into develop Nov 2, 2023
5 of 6 checks passed
@GPortas GPortas deleted the feature/187-files-table-download-button branch November 2, 2023 13:00
jayanthkomarraju pushed a commit to jayanthkomarraju/dataverse-frontend that referenced this pull request May 31, 2024
…d-button

187 - Files table download button
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Size: 3 A percentage of a sprint. 2.1 hours.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Frontend] Files Table Download Button
4 participants