208 - Fix Files table incorrect behavior when changing page size #212
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR fixes an issue in develop where when changing the page size of the Files Table from a bigger size to a smaller size, being the current page the last page of the pagination, the Files Table shows the Files not found message. The expected behaviour is that the Files Table should show the list of files.
Which issue(s) this PR closes:
Special notes for your reviewer:
I didn't add an e2e test because I was able to reproduce the bug with unit tests, so I just added some unit tests.
Suggestions on how to test this:
Step 1: Run the development environment
npm i
cd packages/design-system && npm run build
cd ../../
.env
file such as the .env.example, with theVITE_DATAVERSE_BACKEND_URL=http://localhost:8000
variablecd dev-env
./run-env.sh unstable
Step 2: Test Dataset View mode with the implemented changes for the getDatasetFilesTotalDownloadSize
?persistentId=doi:10.5072/FK2/LHGRHP&version=DRAFT
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
No
Is there a release notes update needed for this change?:
No
Additional documentation: