Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

210 fix e2e tests #216

Merged
merged 14 commits into from
Nov 23, 2023
Merged

210 fix e2e tests #216

merged 14 commits into from
Nov 23, 2023

Conversation

ekraffmiller
Copy link
Contributor

@ekraffmiller ekraffmiller commented Nov 1, 2023

What this PR does / why we need it:

Which issue(s) this PR closes:

Special notes for your reviewer:

Suggestions on how to test this:

Run the Cypress e2e tests:
npm run test:e2e
Check that the integration tests which depend on publishing and ingest run successfully.

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

no

Is there a release notes update needed for this change?:

no

Additional documentation:

@ekraffmiller ekraffmiller marked this pull request as draft November 1, 2023 21:36
@ekraffmiller ekraffmiller marked this pull request as ready for review November 2, 2023 13:20
@ekraffmiller ekraffmiller linked an issue Nov 2, 2023 that may be closed by this pull request
@coveralls
Copy link

coveralls commented Nov 2, 2023

Coverage Status

coverage: 98.312%. remained the same
when pulling 65a883e on 210-fix-e2e-tests
into 563f95d on develop.

@MellyGray MellyGray self-assigned this Nov 6, 2023
Copy link
Contributor

@MellyGray MellyGray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this test gets the total download size of all files in a dataset when passing files criteria also needs to wait for the locks

@MellyGray MellyGray assigned ekraffmiller and unassigned MellyGray Nov 6, 2023
@ekraffmiller
Copy link
Contributor Author

Thanks Melina! I made the changes you requested.

Copy link
Contributor

@MellyGray MellyGray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

@MellyGray MellyGray removed their assignment Nov 7, 2023
@cmbz cmbz added the Size: 10 A percentage of a sprint. 7 hours. label Nov 9, 2023
@GPortas GPortas self-assigned this Nov 23, 2023
@GPortas GPortas merged commit 0d9e8f1 into develop Nov 23, 2023
10 of 12 checks passed
@GPortas GPortas deleted the 210-fix-e2e-tests branch November 23, 2023 11:50
jayanthkomarraju pushed a commit to jayanthkomarraju/dataverse-frontend that referenced this pull request May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Size: 10 A percentage of a sprint. 7 hours.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use Dataset locks API to fix e2e timing errors
5 participants