Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

206 - Integration dataset locks #219

Merged
merged 6 commits into from
Nov 23, 2023

Conversation

MellyGray
Copy link
Contributor

What this PR does / why we need it:

This PR adds the integration of the SPA with the js-dataverse implementation to get the dataset locks.

Which issue(s) this PR closes:

Special notes for your reviewer:

I didn't add an e2e test because the integration + unit tests seemed enough.

Suggestions on how to test this:

Step 1: Run the development environment

  1. Run npm I
  2. cd packages/design-system && npm run build
  3. cd ../../
  4. Check that you have a .env file such as the .env.example, with the VITE_DATAVERSE_BACKEND_URL=http://localhost:8000 variable
  5. cd dev-env
  6. ./run-env.sh unstable
  7. To check the environment go to http://localhost:8000 and check your local dataverse installation

Step 2: Test Dataset View mode with the implemented changes

  1. Go to http://localhost:8000
  2. Login as admin using username: dataverseAdmin and password: admin1
  3. Create a new Dataset
  4. Force a publication lock in the dataset using curl -H "X-Dataverse-key: $API_TOKEN" -X POST "$SERVER_URL/api/datasets/$ID/lock/finalizePublication" Check docs
  5. From the dataset view mode copy the search parameters from the url. Ex.: ?persistentId=doi:10.5072/FK2/LHGRHP&version=DRAFT
  6. Go to http://localhost:8000/spa/datasets and paste the search parameters. Ex.: http://localhost:8000/spa/datasets?persistentId=doi:10.5072/FK2/LHGRHP&version=DRAFT
  7. You are seeing now the same Dataset in the SPA. Check that the buttons disabled in JSF are also disabled in the SPA.

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

No

Is there a release notes update needed for this change?:

No

Additional documentation:

@MellyGray MellyGray marked this pull request as ready for review November 6, 2023 17:35
@MellyGray MellyGray added the Size: 3 A percentage of a sprint. 2.1 hours. label Nov 6, 2023
@coveralls
Copy link

coveralls commented Nov 6, 2023

Coverage Status

coverage: 98.32% (+0.008%) from 98.312%
when pulling 622b8a3 on feauter/206-integration-dataset-locks
into 0d9e8f1 on develop.

@ekraffmiller ekraffmiller self-assigned this Nov 7, 2023
Copy link
Contributor

@ekraffmiller ekraffmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

Base automatically changed from 210-fix-e2e-tests to develop November 23, 2023 11:50
@GPortas GPortas self-assigned this Nov 23, 2023
@MellyGray MellyGray linked an issue Nov 23, 2023 that may be closed by this pull request
@GPortas
Copy link
Contributor

GPortas commented Nov 23, 2023

Looks good!

spadisabledbuttons

@GPortas GPortas merged commit 745e2e9 into develop Nov 23, 2023
10 of 12 checks passed
@GPortas GPortas deleted the feauter/206-integration-dataset-locks branch November 23, 2023 16:13
jayanthkomarraju pushed a commit to jayanthkomarraju/dataverse-frontend that referenced this pull request May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Size: 3 A percentage of a sprint. 2.1 hours.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integration - Get dataset locks
4 participants