Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

207 - Integration get deaccessioned dataset #225

Merged
merged 4 commits into from
Dec 11, 2023

Conversation

MellyGray
Copy link
Contributor

@MellyGray MellyGray commented Nov 8, 2023

What this PR does / why we need it:

This PR adds the integration with js-dataverse module to get the metadata information of deaccessioned datasets in order to display it in the Dataset View Mode.

Which issue(s) this PR closes:

Special notes for your reviewer:

While I was doing the integration I realised that in order to display the Dataset page for a deaccessioned data we also need to integrate the get dataset citation of deaccessioned datasets. I opened an issue to address this change, so in this PR you won't be able to open the Dataset page for a deaccessioned dataset.

Suggestions on how to test this:

Step 1: Run the development environment

  1. Run npm I
  2. cd packages/design-system && npm run build
  3. cd ../../
  4. Check that you have a .env file such as the .env.example, with the VITE_DATAVERSE_BACKEND_URL=http://localhost:8000 variable
  5. cd dev-env
  6. ./run-env.sh unstable
  7. To check the environment go to http://localhost:8000 and check your local dataverse installation

Step 2: Test Dataset View mode with the implemented changes for the getFilesTotalDownloadSize

  1. Go to http://localhost:8000
  2. Login as admin using username: dataverseAdmin and password: admin1
  3. Create a new Dataset
  4. From the dataset view mode copy the search parameters from the url. Ex.: ?persistentId=doi:10.5072/FK2/LHGRHP&version=DRAFT
  5. Go to http://localhost:8000/spa/datasets and paste the search parameters. Ex.: http://localhost:8000/spa/datasets?persistentId=doi:10.5072/FK2/LHGRHP&version=DRAFT
  6. You are seeing now the same Dataset in the SPA, it should work as usually. As I described above this PR cannot display a deaccessioned dataset on it's own, in order to do that we need to finish this other issue Get dataset citation for a deaccessioned dataset #223

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

No

Is there a release notes update needed for this change?:

No

Additional documentation:

@MellyGray MellyGray linked an issue Nov 8, 2023 that may be closed by this pull request
@MellyGray MellyGray marked this pull request as ready for review November 8, 2023 10:40
@MellyGray MellyGray added the Size: 3 A percentage of a sprint. 2.1 hours. label Nov 8, 2023
@coveralls
Copy link

coveralls commented Nov 8, 2023

Coverage Status

coverage: 98.426%. remained the same
when pulling e590e48 on feature/207-integration-get-deaccessioned-dataset
into 0c9a2b8 on develop.

…into feature/207-integration-get-deaccessioned-dataset
@MellyGray MellyGray added the integration Tasks involving the connection and interaction of UI features with the Dataverse API label Dec 4, 2023
@GPortas GPortas self-assigned this Dec 11, 2023
Copy link
Contributor

@GPortas GPortas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@GPortas GPortas removed their assignment Dec 11, 2023
@GPortas GPortas merged commit c5c59d7 into develop Dec 11, 2023
10 of 12 checks passed
@GPortas GPortas deleted the feature/207-integration-get-deaccessioned-dataset branch December 11, 2023 10:42
jayanthkomarraju pushed a commit to jayanthkomarraju/dataverse-frontend that referenced this pull request May 31, 2024
…ccessioned-dataset

207 - Integration get deaccessioned dataset
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration Tasks involving the connection and interaction of UI features with the Dataverse API Size: 3 A percentage of a sprint. 2.1 hours.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Get deaccessioned dataset
3 participants