Feature/188 dataset download options #232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MellyGray
requested changes
Nov 17, 2023
src/sections/dataset/dataset-action-buttons/DatasetActionButtons.tsx
Outdated
Show resolved
Hide resolved
src/sections/dataset/dataset-action-buttons/access-dataset-menu/AccessDatasetMenu.tsx
Outdated
Show resolved
Hide resolved
src/sections/dataset/dataset-action-buttons/access-dataset-menu/AccessDatasetMenu.tsx
Outdated
Show resolved
Hide resolved
src/sections/dataset/dataset-action-buttons/access-dataset-menu/AccessDatasetMenu.tsx
Outdated
Show resolved
Hide resolved
...onent/sections/dataset/dataset-action-buttons/access-dataset-menu/AccessDatasetMenu.spec.tsx
Outdated
Show resolved
Hide resolved
|
Thanks Melina! I made the changes you suggested. |
MellyGray
approved these changes
Nov 22, 2023
|
@ekraffmiller Please, can you resolve the conflicts? |
|
@ekraffmiller For stories in the AccessDatasetMenu section in Storybook, I see that there is an extra parenthesis.
For stories directly under DatasetActionButtons folder, in addition to the extra parenthesis I find empty values. Only With Publish Permissions has values. I'm not sure if this is correct, but it looks a little confusing:
|
MellyGray
added
the
UI
ekraffmiller
added
Size: 3
|
Thanks @GPortas, I made some fixes, ready for QA again |
GPortas
requested changes
Dec 12, 2023
|
ugh, sorry I missed that one! Should be fixed now. |
|
removed extra parenthesis |
jayanthkomarraju
pushed a commit
to jayanthkomarraju/dataverse-frontend
that referenced
this pull request
May 31, 2024
…tions Feature/188 dataset download options
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Implements the download options for the AccessDatasetMenu
Which issue(s) this PR closes:
Special notes for your reviewer:
Suggestions on how to test this:
Review the Stories in AccessDatasetMenu
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?:
Additional documentation: