229 - Basic home page with the list of datasets #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into feature/229-basic-home-page-with-the-list-of-datasets
MellyGray
added
the
UI
|
@MellyGray Please, can you resolve conflicts? |
…into feature/229-basic-home-page-with-the-list-of-datasets
|
@GPortas conflicts resolved, there's an e2e test failing but it's the one that it's going to be fixed with |
GPortas
approved these changes
Dec 12, 2023
|
@GPortas I know the boilerplate UI is kind of ugly, we could merge this other PR here so the ugly UI doesn't make it into beta: |
|
Waiting for #248 to be merged |
…e-page 230 - Add dataset card info to Home page
|
@MellyGray Can you please resolve the conflicts? |
…into feature/229-basic-home-page-with-the-list-of-datasets
|
@GPortas conflicts resolved |
|
Now that #248 has been merged into this PR, can we remove the "waiting" label? |
GPortas
deleted the
feature/229-basic-home-page-with-the-list-of-datasets
branch
jayanthkomarraju
pushed a commit
to jayanthkomarraju/dataverse-frontend
that referenced
this pull request
May 31, 2024
…h-the-list-of-datasets 229 - Basic home page with the list of datasets
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds a basic home page to the SPA to display a list of available datasets to the user. Note that this is only the frontend so is not connected with the backend yet.
Which issue(s) this PR closes:
Special notes for your reviewer:
I refactored FilePaginationInfo class to extract a common class between FilePaginationInfo and DatasetPaginationInfo, this way we can rehuse the pagination functionality.
I'm aware that the Dataverse home page shows collections, datasets and files, but for the aim of simplicity in this first iteration only the datasets are being displayed.
Suggestions on how to test this:
npm install.cd packages/design-system && npm run build.cd ../../.npm run storybook.Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?:
Datasets list added to the SPA home page
Additional documentation: