Feature/223 integration citation for deaccessioned dataset

[ekraffmiller]

What this PR does / why we need it:

Update package.json to use dataverse-client-javascript that returns deaccessioned dataset, add Story and e2e test for Deaccessioned Dataset

Which issue(s) this PR closes:

• Closes Get dataset citation for a deaccessioned dataset #223

Special notes for your reviewer:

Please ignore the commits to AccessFileMenu.tsx, I thought I needed to change the rendering logic, but it was working correctly, so reverted it back.

Suggestions on how to test this:

Run the e2e test, view the Deaccessioned Dataset

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

No

Is there a release notes update needed for this change?:

No

Additional documentation:

[coveralls]

coverage: 97.922%. remained the same
when pulling 4c35f2a on feature/223-integration-citation-for-deaccessioned-dataset
into bab6619 on develop.

[MellyGray]

@ekraffmiller is this issue ready for review? can you change the PR from draft to ready for review? also, can you take a look at the conflicts?

[ekraffmiller]

Thanks @MellyGray , I made the requested changes

[ekraffmiller]

@MellyGray The e2e test is failing, I think it is still the timing error caused by the FilePermissions Hook. Even though the error is different, the fact that it's happening at the same place and only happens intermittently makes me suspicious. :(
The error is only happening in Github, I can't reproduce it locally.

As we talked about before, when I tried to solve the timing error by refactoring the permissions, I just simplified the hooks, I didn't remove them altogether. Maybe we should create a new ticket to do that? I have my code from before saved in another branch, so I think it wouldn't be too time consuming.

[MellyGray]

@ekraffmiller Sure, go ahead and create the new ticked to remove the permissions hook. I think it makes sense to prioritize the refactor since changes to the File model may affect the new File page

[GPortas]

Looks good!