236 - Cypress timing error #255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MellyGray
approved these changes
Dec 12, 2023
jayanthkomarraju
pushed a commit
to jayanthkomarraju/dataverse-frontend
that referenced
this pull request
May 31, 2024
236 - Cypress timing error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
In the e2e test, the Dataset tests are sometimes failing because the page is asynchronously updated during the Cypress call to click the AccessFileMenu. To avoid this, the Cypress command for finding the button and the call to click the button are separated into two statements.
here is Cypress documentation on the issue: https://docs.cypress.io/guides/references/error-messages#cy-failed-because-the-page-updated
Which issue(s) this PR closes:
Special notes for your reviewer:
Due to the timing nature of the error, it's hard to reproduce consistently. I was able to get my local dev environment in a state where it was happening by adding some console.log statements, and when I applied the fix, the error no longer happened.
Suggestions on how to test this:
Run the e2e test locally and check the e2e test on Github Actions.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
no
Is there a release notes update needed for this change?:
no
Additional documentation: