-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
244 - Integration download dataset #256
Conversation
@MellyGray Can you please resolve conflicts? |
…into feature/244-integration-download-all-files
@GPortas conflicts resolved |
}, // TODO Connect with JS dataset permissions for privateUrl when it is available in js-dataverse | ||
[], // TODO Connect with JS dataset locks for privateUrl when it is available in js-dataverse | ||
0, // TODO Connect with JS dataset filesTotalDownloadSize for privateUrl when it is available in js-dataverse | ||
0 // TODO Connect with JS dataset filesTotalDownloadSize for privateUrl when it is available in js-dataverse |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we create an issue including all these TODOs related to private URLs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I created an issue
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
downloaddataset.mov
@MellyGray Can you please resolve merge conflicts? |
…into feature/244-integration-download-all-files
@GPortas conflicts resolved |
…d-all-files 244 - Integration download dataset
What this PR does / why we need it:
This PR adds the integration to download the dataset using the Dataverse API. With this integration the user would be able to download the dataset both in original and archival formats using the Access Dataset button in the Dataset page.
Which issue(s) this PR closes:
Special notes for your reviewer:
Suggestions on how to test this:
Step 1: Run the development environment
npm I
cd packages/design-system && npm run build
cd ../../
.env
file such as the .env.example, with theVITE_DATAVERSE_BACKEND_URL=http://localhost:8000
variablecd dev-env
./run-env.sh unstable
Step 2: Test Dataset View mode with the implemented changes to download the files
?persistentId=doi:10.5072/FK2/LHGRHP&version=DRAFT
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
No
Is there a release notes update needed for this change?:
No
Additional documentation: