-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/489 dynamic root alias #530
Conversation
…fault instead) Updated components that depend on collectionId.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I’ve tested this in my local environment and it works great! 🎉
Nice work @ekraffmiller, this is a very nice addition to the SPA!
I just left some minor improvements that could be done.
Tested locally - everything looks good. Did additional regression test on storybook (no issues there). |
What this PR does / why we need it:
This PR removes the use of 'root' as a constant to refer to the alias of the root collection. Instead, it depends on js-dataverse to use the default root collection id, ':root' to get the root collection.
Which issue(s) this PR closes:
Special notes for your reviewer:
The logic for handling the loading state of the Collection in Account.tsx and LoggedInHeaderActions.tsx needs a closer review, I wasn't sure the best way to handle the isLoading state.
Suggestions on how to test this:
Step 1: Run the Development Environment
npm i
.cd packages/design-system && npm run build
.cd ../../
..env
file similar to.env.example
, with the variableVITE_DATAVERSE_BACKEND_URL=http://localhost:8000
.cd dev-env
../run-env.sh unstable
.Step 2: Test the feature
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?:
Additional documentation: