Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the data format of File's creationDate and publishDate from Date to string #563

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

ChengShi-1
Copy link
Contributor

@ChengShi-1 ChengShi-1 commented Dec 6, 2024

What this PR does / why we need it:

Change the e file creation date and publication date from Date object to string type(as same as the payload format) to avoid a date conflict

Which issue(s) this PR closes:

Special notes for your reviewer:

waiting for IQSS/dataverse-client-javascript#226 to be merged.
Once it merged, the package.json should be deleted and not merge into main branch.

Suggestions on how to test this:

  • find an existing dataset, or create a new dataset
  • upload a file to a dataset, check file deposited date, should be in format 2024-12-16 and correct date
  • published the file and check the date in the same place again
    image

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

No

Is there a release notes update needed for this change?:

No

Additional documentation:

@coveralls
Copy link

coveralls commented Dec 7, 2024

Coverage Status

coverage: 97.363% (+0.02%) from 97.345%
when pulling 36e6311 on 560-feature-requestidea-show-a-string-for-the-creation-date-and-publication-date-of-file
into 02b04e5 on develop.

@ChengShi-1 ChengShi-1 added FY25 Sprint 12 FY25 Sprint 12 (2024-12-04 - 2024-12-18) Size: 3 A percentage of a sprint. 2.1 hours. SPA: File Page GREI Re-arch GREI re-architecture-related Original size: 3 SPA.Q4.10 Resolve TODOs and tech debt Waiting labels Dec 11, 2024
@ChengShi-1 ChengShi-1 self-assigned this Dec 12, 2024
@ChengShi-1 ChengShi-1 marked this pull request as ready for review December 13, 2024 09:26
@ChengShi-1 ChengShi-1 removed their assignment Dec 13, 2024
@g-saracca g-saracca self-assigned this Dec 13, 2024
@ChengShi-1 ChengShi-1 removed their assignment Dec 16, 2024
@g-saracca g-saracca removed their assignment Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FY25 Sprint 12 FY25 Sprint 12 (2024-12-04 - 2024-12-18) GREI Re-arch GREI re-architecture-related Original size: 3 Size: 3 A percentage of a sprint. 2.1 hours. SPA: File Page SPA.Q4.10 Resolve TODOs and tech debt Waiting
Projects
Status: Ready for QA ⏩
Development

Successfully merging this pull request may close these issues.

Feature Request/Idea: Show a string for the creation date and publication date of file
3 participants