-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change the data format of File's creationDate and publishDate from Date to string #563
Open
ChengShi-1
wants to merge
7
commits into
develop
Choose a base branch
from
560-feature-requestidea-show-a-string-for-the-creation-date-and-publication-date-of-file
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChengShi-1
added
FY25 Sprint 12
FY25 Sprint 12 (2024-12-04 - 2024-12-18)
Size: 3
A percentage of a sprint. 2.1 hours.
SPA: File Page
GREI Re-arch
GREI re-architecture-related
Original size: 3
SPA.Q4.10
Resolve TODOs and tech debt
Waiting
labels
Dec 11, 2024
g-saracca
requested changes
Dec 16, 2024
…ra return keyword
g-saracca
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
FY25 Sprint 12
FY25 Sprint 12 (2024-12-04 - 2024-12-18)
GREI Re-arch
GREI re-architecture-related
Original size: 3
Size: 3
A percentage of a sprint. 2.1 hours.
SPA: File Page
SPA.Q4.10
Resolve TODOs and tech debt
Waiting
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Change the e file creation date and publication date from Date object to string type(as same as the payload format) to avoid a date conflict
Which issue(s) this PR closes:
Special notes for your reviewer:
waiting for IQSS/dataverse-client-javascript#226 to be merged.
Once it merged, the
package.json
should be deleted and not merge into main branch.Suggestions on how to test this:
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
No
Is there a release notes update needed for this change?:
No
Additional documentation: