-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Collection Page Facets Filters #566
Open
g-saracca
wants to merge
27
commits into
develop
Choose a base branch
from
feat/562-add-collection-facets
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
g-saracca
changed the title
Feat/562 add collection facets
Collection Page Facets Filters
Dec 12, 2024
g-saracca
added
GREI Re-arch
GREI re-architecture-related
SPA.Q4.1
Collection Page: All Filtering Options
Size: 3
A percentage of a sprint. 2.1 hours.
Original size: 3
labels
Dec 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks great! Just a minor comment about the query parameters.
tests/e2e-integration/e2e/sections/collection/CollectionItemsPanel.spec.ts
Outdated
Show resolved
Hide resolved
@ekraffmiller thanks, ready for review again! |
ekraffmiller
approved these changes
Dec 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, approved!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
GREI Re-arch
GREI re-architecture-related
Original size: 3
Size: 3
A percentage of a sprint. 2.1 hours.
SPA.Q4.1
Collection Page: All Filtering Options
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds the facet filtes in the Collection Page.
See original issue
Which issue(s) this PR closes:
Special notes for your reviewer:
Depends on IQSS/dataverse-client-javascript#230 PR.
dataverse-client-javascript
package version should be updated to the alpha one once the mentioned above is merged.Suggestions on how to test this:
Step 1: Run the Development Environment
npm i
.cd packages/design-system && npm i && npm run build
.cd ../../
..env
file similar to.env.example
, with the variableVITE_DATAVERSE_BACKEND_URL=http://localhost:8000
.cd dev-env
../run-env.sh unstable
.Step 2: Test the feature
http://localhost:8000/spa/collections
and in another tab tohttp://localhost:8000
and apply same filters in the SPA version and JSF version (search; filter by collection, datasets or files; select and remove facets). Check that they show the same items and facets list.*Note that for now, for the selected facets button labels, we are only showing the facet value, so when in the JSF version you will see "Author Name: John" in the SPA you will just see "John".
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Yes.
Is there a release notes update needed for this change?:
No
Additional documentation:
No