Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solr 9.7.0 and other lib updates from QDR #10713

Open
wants to merge 11 commits into
base: develop
Choose a base branch
from

Conversation

qqmyers
Copy link
Member

@qqmyers qqmyers commented Jul 21, 2024

What this PR does / why we need it: QDR has updated to Solr 9.7.0 and uses other libraries that are more recent than the community version. This PR shows what QDR has changed.

Which issue(s) this PR closes:

Closes #

Special notes for your reviewer:

Suggestions on how to test this: Generally test indexing, regression, test the solr install docs, test that the Circuit breaker works at Harvard (@landreev might be able to help here)

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

Is there a release notes update needed for this change?: included
Additional documentation:

@qqmyers qqmyers added the Size: 3 A percentage of a sprint. 2.1 hours. label Jul 21, 2024
@coveralls
Copy link

coveralls commented Sep 3, 2024

Coverage Status

coverage: 22.571%. remained the same
when pulling 12fe003 on QualitativeDataRepository:QDR-solr_and_libs_updates
into e3b5795 on IQSS:develop.

pdurbin
pdurbin previously requested changes Oct 9, 2024
Copy link
Member

@pdurbin pdurbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request is not complete. When we upgrade Solr we updated docs, Docker files, etc. Please see #10636 for example.

@pdurbin pdurbin added the Type: Feature a feature request label Oct 9, 2024
@qqmyers
Copy link
Member Author

qqmyers commented Oct 10, 2024

Thankfully many few places to change now that the files go in /conf/solr! As of now, the only 9.4.1 references are in the old release notes.

@qqmyers qqmyers removed their assignment Oct 10, 2024
@pdurbin
Copy link
Member

pdurbin commented Nov 7, 2024

Solr is such a moving target. 9.7 is out. Do we care? Stick with 9.6.1? https://solr.apache.org/downloads.html

p.s. There are merge conflicts.

@pdurbin
Copy link
Member

pdurbin commented Dec 4, 2024

Again, Solr is such a moving target. 9.7 is out. Do we care? Stick with 9.6.1? https://solr.apache.org/downloads.html

p.s. There are merge conflicts.

@qqmyers qqmyers changed the title Solr 9.6.1 and other lib updates from QDR Solr 9.7.0 and other lib updates from QDR Dec 12, 2024
@qqmyers
Copy link
Member Author

qqmyers commented Dec 18, 2024

FYI - @donsizemore ran this with solr 9.7.0 to show the tests pass - in https://jenkins.dataverse.org/job/IQSS-Dataverse-Solr_9.7.0/4/console.
Since the solrconfig.xml appears to not be compatible with solr 9.4.1, it looks like we need to update the normal build once this is merged to get the IT tests to work on develop.

Copy link
Member

@pdurbin pdurbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm just clearing "request changes" now that we're trying with the latest Solr (9.7).

@pdurbin pdurbin dismissed their stale review December 18, 2024 15:57

The latest Solr is used (9.7).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Size: 3 A percentage of a sprint. 2.1 hours. Type: Feature a feature request
Projects
Status: SPRINT READY
Development

Successfully merging this pull request may close these issues.

3 participants