Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update input_functions.R #65

Merged
merged 1 commit into from
Feb 22, 2024
Merged

Update input_functions.R #65

merged 1 commit into from
Feb 22, 2024

Conversation

nmueller18
Copy link
Member

According to issue #64 (comment).

According to issue.
@codecov-commenter
Copy link

codecov-commenter commented Feb 18, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (1bb5cea) 93.70% compared to head (fa1b4f4) 93.55%.

❗ Current head fa1b4f4 differs from pull request most recent head 35f1227. Consider uploading reports for the commit 35f1227 to get more accurate results

Files Patch % Lines
R/input_functions.R 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #65      +/-   ##
==========================================
- Coverage   93.70%   93.55%   -0.16%     
==========================================
  Files          10       10              
  Lines         604      605       +1     
==========================================
  Hits          566      566              
- Misses         38       39       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MartinHinz
Copy link
Member

Thank you for your efforts, I approve this PR. Do we wait until @chrinne also have checked this, or do we merge right away?

@chrinne
Copy link
Member

chrinne commented Feb 22, 2024

To late but: yes ok.

@chrinne
Copy link
Member

chrinne commented Feb 22, 2024

To late, but: yes ok.

@chrinne chrinne closed this Feb 22, 2024
@chrinne chrinne reopened this Feb 22, 2024
@chrinne chrinne merged commit 4dc067e into master Feb 22, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants