Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use numpy testing framework and relative differences #104

Merged
merged 3 commits into from
Dec 12, 2024

Conversation

rgieseke
Copy link
Collaborator

@rgieseke rgieseke commented Dec 5, 2024

Also adds a test for y in reference data and fixes a bug with y-values in pr.

@rgieseke rgieseke marked this pull request as ready for review December 5, 2024 10:54
@rgieseke
Copy link
Collaborator Author

rgieseke commented Dec 5, 2024

All tests have passed locally as well.

platform linux -- Python 3.11.10, pytest-8.3.4, pluggy-1.5.0
configfile: pyproject.toml
collected 42 items                                                                                                                                                                                                                           

tests/test_detrend.py .........                                                                                                                                                                                                        [ 21%]
tests/test_preprocessing.py ..                                                                                                                                                                                                         [ 26%]
tests/test_vendored_ssa.py ..............................                                                                                                                                                                              [ 97%]
tests/test_version.py .                                                                                                                                                                                                                [100%]

=== 42 passed

@swillner swillner changed the base branch from develop to codebase_redesign December 5, 2024 12:49
tests/test_detrend.py Show resolved Hide resolved
tests/test_detrend.py Show resolved Hide resolved
tests/test_detrend.py Show resolved Hide resolved
@rgieseke rgieseke changed the base branch from codebase_redesign to develop December 12, 2024 15:01
@rgieseke rgieseke changed the base branch from develop to codebase_redesign December 12, 2024 15:02
@rgieseke rgieseke changed the base branch from codebase_redesign to develop December 12, 2024 15:07
rgieseke and others added 2 commits December 12, 2024 16:14
This also fixes a bug with y-values in pr.

Co-authored-by: Sven Willner <[email protected]>
Co-authored-by: Robert Gieseke <[email protected]>
This should help setting appropriate tolerance values.
@matthiasmengel matthiasmengel merged commit 64d94d0 into ISI-MIP:develop Dec 12, 2024
1 check passed
@rgieseke rgieseke deleted the tests-np-allclose branch December 12, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants