Improvements for tests #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -93,19 +86,22 @@ def add_parser(subparsers): | |||
| group.add_argument( | |||
| "--modes", | |||
| type=int, | |||
| default=4, | |||
| default=Config.__dataclass_fields__["modes"].default, | |||
There was a problem hiding this comment.
Is this better than hardcoded values for tests? A user may change them and break tests by accident.
There was a problem hiding this comment.
Not sure I understand correctly, but the change to use Config.__dataclass_fields__["modes"].default is to read the default from the 'Config' object in detrend.py as a single source of truth for the default.
Sorry, we should have put this more clearly in the PR description.
Also refactors Config object and default arguments.
- use functions - use numpy testing for comparison - refactor metadata creation
rgieseke
force-pushed
the
tests-adjustment
branch
from
e61d602 to
7fc2c3e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests which were previously run only locally are now also running in CI (including the slow ones it takes about 3min).
Use detrend function for testing
Adjust SSA tests and add provenance
🚀