Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate to nuxt3 #191

Open
wants to merge 111 commits into
base: development
Choose a base branch
from
Open

migrate to nuxt3 #191

wants to merge 111 commits into from

Conversation

ckouder
Copy link
Collaborator

@ckouder ckouder commented May 8, 2023

As tested in my local environment, I believe the migration is 99% done. I used node v18.13.0 on my local machine. It works as charm. The migration removes any deprecated or incompatible plugins from nuxt 2 and find substitution in nuxt 3.

The removed plugins include:

  • @nuxtjs/axios
  • @nuxtjs/sentry
  • @sentry/tracing
  • vue-chartist
  • vue2-filters

The substituted plugins include:

  • @nuxtjs/auth-next >>> @sidebase/nuxt-auth
  • json-schema-ref-parser >>> @stoplight/json-ref-resolver
  • vue-sanitize >>> dompurify
  • vue-lazy-hydration >>> nuxt-lazy-hydration
  • jest >>> vitest
  • vuex >>> pinia

The only two problems I observed are:

  • new google analytics plugin vue-gtag does not support universal analytics; the latter will be deprecated in July. However, we did not provide a GA4 ID yet.
  • the component v-data-table is experimental in Vuetify 3. It introduces some weird sorting mechanisms that doesn't work with our API which i'm still looking for a workaround. Luckily, the component only impacts several admin pages. Other than that, I believe we should anticipate a fluent user experience.

In addition, I notice there are some visual inconsistencies across several pages. e.g, the titles of search page and artifact import page are misaligned, wrong fonts are used for text-field label, wrong v-container hierarchies, etc. So I provide some quick fix as well.

Another thing to talk about is code refractor -- the visual inconsistencies are largely due to unnecessary, and often incorrect code repetitions across different pages. It should be refractored properly to reduce errors of this kind. The following code blocks are repetitive and, I think should be refractored:

  • the logo and title inside pages/favorites, pages/import, pages/index, pages/myartifacts, pages/search, maybe we can refractor those common elements into a separate layout file
  • the layout in all pages in pages/admin except importers are very similar, i believe a similar approach might also be applicable. (maybe I'm wrong)

Lastly, style tweak should be seriously considered after this migration due to the change of prime color of vuetify. The current theme will cause eyes pain. : p

I'm also using this thread as a feedback hub. Please use replies to let me know if anything is broken on your machine. I will provide a fix.

@ckouder
Copy link
Collaborator Author

ckouder commented Jul 27, 2023

Hello @carboxylman, can you please check if there is any problem related to migration I need to further work on? I just fixed theme. So far everything looks good to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant