-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
migrate to nuxt3 #191
Open
ckouder
wants to merge
111
commits into
development
Choose a base branch
from
167-migrate-to-nuxt3
base: development
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
migrate to nuxt3 #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hello @carboxylman, can you please check if there is any problem related to migration I need to further work on? I just fixed theme. So far everything looks good to me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As tested in my local environment, I believe the migration is 99% done. I used node v18.13.0 on my local machine. It works as charm. The migration removes any deprecated or incompatible plugins from nuxt 2 and find substitution in nuxt 3.
The removed plugins include:
@nuxtjs/axios
@nuxtjs/sentry
@sentry/tracing
vue-chartist
vue2-filters
The substituted plugins include:
@nuxtjs/auth-next
>>>@sidebase/nuxt-auth
json-schema-ref-parser
>>>@stoplight/json-ref-resolver
vue-sanitize
>>>dompurify
vue-lazy-hydration
>>>nuxt-lazy-hydration
jest
>>>vitest
vuex
>>>pinia
The only two problems I observed are:
vue-gtag
does not support universal analytics; the latter will be deprecated in July. However, we did not provide a GA4 ID yet.v-data-table
is experimental in Vuetify 3. It introduces some weird sorting mechanisms that doesn't work with our API which i'm still looking for a workaround. Luckily, the component only impacts several admin pages. Other than that, I believe we should anticipate a fluent user experience.In addition, I notice there are some visual inconsistencies across several pages. e.g, the titles of search page and artifact import page are misaligned, wrong fonts are used for text-field label, wrong v-container hierarchies, etc. So I provide some quick fix as well.
Another thing to talk about is code refractor -- the visual inconsistencies are largely due to unnecessary, and often incorrect code repetitions across different pages. It should be refractored properly to reduce errors of this kind. The following code blocks are repetitive and, I think should be refractored:
pages/favorites
,pages/import
,pages/index
,pages/myartifacts
,pages/search
, maybe we can refractor those common elements into a separate layout filepages/admin
exceptimporters
are very similar, i believe a similar approach might also be applicable. (maybe I'm wrong)Lastly, style tweak should be seriously considered after this migration due to the change of prime color of vuetify. The current theme will cause eyes pain. : p
I'm also using this thread as a feedback hub. Please use replies to let me know if anything is broken on your machine. I will provide a fix.