Make ProjMPS accessible #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If it wasn't exported before, it shouldn't be exported now. However, we can make it accessible as |
|
Thanks – I updated this PR along the lines of #6 . I bumped the patch version too, but can reset it if that's too much. |
|
Thanks! I think this is an interesting process to go through, since we can get an idea for which packages are using "internal" (non-exported) functionality of ITensorMPS. Glad to see it is not too extensive and most packages are using exported functionality. |
|
True! It's pretty interesting what is revealed by splitting packages up more finely. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
ProjMPSto the list of exports. This is needed by other packages such asITensorQTT. I tried just writingITensorMPS.ProjMPSbut I believe since theITensorMPSpackage only does reexports, unexported methods may not be accessible throughITensorMPS.