Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some issues around keyword arguments #114

Merged
merged 2 commits into from
Nov 3, 2023
Merged

Fix some issues around keyword arguments #114

merged 2 commits into from
Nov 3, 2023

Conversation

mtfishman
Copy link
Member

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Nov 3, 2023

Codecov Report

Merging #114 (147d8e4) into main (fd19eef) will increase coverage by 0.19%.
Report is 2 commits behind head on main.
The diff coverage is 88.23%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##             main     #114      +/-   ##
==========================================
+ Coverage   78.74%   78.93%   +0.19%     
==========================================
  Files          65       65              
  Lines        3726     3713      -13     
==========================================
- Hits         2934     2931       -3     
+ Misses        792      782      -10     
Files Coverage Δ
src/abstractitensornetwork.jl 85.68% <100.00%> (ø)
src/gauging.jl 100.00% <100.00%> (ø)
src/treetensornetworks/solvers/contract.jl 91.30% <100.00%> (ø)
src/treetensornetworks/solvers/dmrg.jl 100.00% <100.00%> (ø)
src/treetensornetworks/solvers/dmrg_x.jl 100.00% <100.00%> (ø)
src/treetensornetworks/solvers/linsolve.jl 100.00% <ø> (+40.00%) ⬆️
src/treetensornetworks/solvers/update_step.jl 82.85% <100.00%> (ø)
src/treetensornetworks/solvers/applyexp.jl 0.00% <0.00%> (ø)
src/treetensornetworks/solvers/tdvp.jl 72.41% <80.00%> (+4.15%) ⬆️

@mtfishman
Copy link
Member Author

@JoeyT1994 this fixes the test errors caused by stricter keyword argument handling introduced in ITensor/ITensors.jl#1226.

@mtfishman mtfishman merged commit 97449cd into main Nov 3, 2023
8 of 9 checks passed
@mtfishman mtfishman deleted the kwargs_cleanup branch November 3, 2023 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants