Add functionality for loading setup code #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #41 +/- ##
=====================================
Coverage 6.02% 6.02%
=====================================
Files 1 1
Lines 83 83
=====================================
Hits 5 5
Misses 78 78
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Revert "Add functionality for loading setup code" This reverts commit 5ed825c. setup file logic
mtfishman
reviewed
Dec 9, 2024
mtfishman
reviewed
Dec 9, 2024
mtfishman
reviewed
Dec 9, 2024
This was referenced Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposition to allow loading setup code through setup modules in either
test/setup/orexamples/setup/. It basically allows any module defined in those folders to be loaded from the tests byusing SetupModule.As a small FYI/question: currently I'm not explicitly blacklisting that folder from the testfiles, and testfiles are still selected on
test_*.jl. I'm not sure if this is important to catch.