Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve the element type properly in tdvp, dmrg_x, etc. #63

Merged
merged 19 commits into from
Feb 16, 2024

Conversation

mtfishman
Copy link
Member

@mtfishman mtfishman commented Feb 15, 2024

Also change some internal uses of tdvp to alternating_update, sweep_update, sub_sweep_update, and region_update, following the names planned in ITensorNetworks.jl.

Additionally, run examples in the tests and update style of import and using for overloading functions and bringing functions and types into namespaces.

@codecov-commenter
Copy link

codecov-commenter commented Feb 15, 2024

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (449e3a4) 84.09% compared to head (82cfcc5) 85.87%.

Files Patch % Lines
src/tdvp.jl 50.00% 4 Missing ⚠️
src/alternating_update.jl 86.66% 2 Missing ⚠️
src/projmps2.jl 60.00% 2 Missing ⚠️
src/sweep_update.jl 91.66% 1 Missing ⚠️
src/tdvporder.jl 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #63      +/-   ##
==========================================
+ Coverage   84.09%   85.87%   +1.77%     
==========================================
  Files          17       17              
  Lines         522      524       +2     
==========================================
+ Hits          439      450      +11     
+ Misses         83       74       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

test/test_dmrg_x.jl Outdated Show resolved Hide resolved
src/tdvp.jl Outdated Show resolved Hide resolved
@mtfishman
Copy link
Member Author

@emstoudenmire this is mostly superficial code cleanup, hopefully we can simplify the situation with reduced/projected operators in this package with the work you are doing rewriting that code in ITensors.jl. Ideally we can get rid of ProjMPOApply in favor of an outer product operator type that will also be used by excited state DMRG, and get rid of ProjMPS2 and ProjMPO_MPS2 (which is a weird hack to the linsolve working) in favor of using existing projected operator types. That might require introducing a LinearProblem type that wraps project operators in order to define which parts are A and b of the linear problem Ax = b (similar to the design of https://github.com/SciML/LinearSolve.jl).

@mtfishman mtfishman merged commit 98885ba into main Feb 16, 2024
8 of 9 checks passed
@mtfishman mtfishman deleted the preserve_eltype branch February 16, 2024 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants