Merge branch 'kmp5/debug/scalar_indexing' of github.com:kmp5VT/ITenso…

…rs.jl into kmp5/debug/scalar_indexing
ITensor · Nov 15, 2023 · 21aa398 · 21aa398
2 parents 85aee99 + 2650f60
commit 21aa398
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 7 deletions.
diff --git a/NDTensors/ext/NDTensorsCUDAExt/NDTensorsCUDAExt.jl b/NDTensors/ext/NDTensorsCUDAExt/NDTensorsCUDAExt.jl
@@ -10,8 +10,6 @@ using CUDA
 using CUDA.CUBLAS
 using CUDA.CUSOLVER
 
-## TODO I added copyto and permutedims which match the functions in 
-## NDTensorsMetalExt because I found similar issues in CUDA
 include("imports.jl")
 include("default_kwargs.jl")
 include("copyto.jl")

diff --git a/NDTensors/ext/NDTensorsCUDAExt/copyto.jl b/NDTensors/ext/NDTensorsCUDAExt/copyto.jl
@@ -1,6 +1,4 @@
-## IT looks like CuArray suffers from the same issues as MtlArray.
-## To fix this subarray copyto problem I copied same code from MetalExt
-## This means we can probably write a generic implmenetation for GPUArrays
+# Same definition as `MtlArray`.
 function Base.copy(src::Exposed{<:CuArray,<:Base.ReshapedArray})
   return reshape(copy(parent(src)), size(unexpose(src)))
 end

diff --git a/NDTensors/ext/NDTensorsCUDAExt/mul.jl b/NDTensors/ext/NDTensorsCUDAExt/mul.jl
@@ -24,8 +24,6 @@ function LinearAlgebra.mul!(
   return unexpose(CM)
 end
 
-## TODO I wasn't sure the best route to go here, if there is a better route than
-## copy please let me know!
 ## Fix issue in CUDA.jl where it cannot distinguish Transpose{Reshape{Adjoint{CuArray}}}
 ## as a CuArray and calls generic matmul
 function LinearAlgebra.mul!(