Skip to content

Commit

Permalink
[NDTensorsMetalExt] Fix issues of not importing some LinearAlgebra fu…
Browse files Browse the repository at this point in the history
…nctions (#1233)
  • Loading branch information
mtfishman authored Nov 3, 2023
1 parent 063ccbe commit 9d4fed1
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
3 changes: 2 additions & 1 deletion NDTensors/ext/NDTensorsMetalExt/NDTensorsMetalExt.jl
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,10 @@ module NDTensorsMetalExt

using Adapt
using Functors
using LinearAlgebra: LinearAlgebra, Transpose, mul!
using LinearAlgebra: LinearAlgebra, Transpose, mul!, qr, eigen, svd
using NDTensors
using NDTensors.SetParameters
using NDTensors.Unwrap: qr_positive, ql_positive, ql

if isdefined(Base, :get_extension)
using Metal
Expand Down
2 changes: 1 addition & 1 deletion NDTensors/src/linearalgebra/svd.jl
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ function svd_recursive(M::AbstractMatrix; thresh::Float64=1E-3, north_pass::Int=

V = M' * U

V, R = qr_positive(V)
V, R = qr_positive(expose(V))
D[1:Nd] = diag(R)[1:Nd]

(done, start) = svd_recursive_state(D, thresh)
Expand Down

0 comments on commit 9d4fed1

Please sign in to comment.