[NDTensors] Fix CPU performance issue caused by bad mul dispatch (#1218)

ITensor · Oct 25, 2023 · bde7da7 · bde7da7
1 parent cea22f9
commit bde7da7
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/NDTensors/src/abstractarray/iswrappedarray.jl b/NDTensors/src/abstractarray/iswrappedarray.jl
@@ -33,6 +33,7 @@ parenttype(::Type{<:UnitUpperTriangular{<:Any,P}}) where {P} = P
 parenttype(::Type{<:UnitLowerTriangular{<:Any,P}}) where {P} = P
 parenttype(::Type{<:Diagonal{<:Any,P}}) where {P} = P
 parenttype(::Type{<:SubArray{<:Any,<:Any,P}}) where {P} = P
+parenttype(::Type{<:StridedView{<:Any,<:Any,P}}) where {P} = P
 
 # For working with instances, not used by
 # `SimpleTraits.jl` traits dispatch.

diff --git a/NDTensors/src/array/permutedims.jl b/NDTensors/src/array/permutedims.jl
@@ -1,6 +1,9 @@
 # NDTensors.permutedims
 function permutedims(::Type{<:Array}, M, perm)
-  return @strided Base.permutedims(M, perm)
+  ## Creating Mperm here to evaluate the permutation and
+  ## avoid returning a Stridedview
+  @strided Mperm = Base.permutedims(M, perm)
+  return Mperm
 end
 
 # NDTensors.permutedims!