Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DMRG.md criticality #1235

Merged
merged 2 commits into from
Nov 3, 2023
Merged

Update DMRG.md criticality #1235

merged 2 commits into from
Nov 3, 2023

Conversation

jtschneider
Copy link
Contributor

Regarding #1234

@mtfishman
Copy link
Member

Could also add a note about criticality to:

ITensors.jl/src/mps/dmrg.jl

Lines 127 to 129 in 9d4fed1

- `eigsolve_krylovdim::Int = 3` - maximum dimension of Krylov space used to
locally solve the eigenvalue problem. Try setting to a higher value if
convergence is slow. [^krylovkit]

@codecov-commenter
Copy link

codecov-commenter commented Nov 3, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (063ccbe) 85.36% compared to head (a77c480) 54.56%.
Report is 1 commits behind head on main.

❗ Current head a77c480 differs from pull request most recent head 930b2d7. Consider uploading reports for the commit 930b2d7 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1235       +/-   ##
===========================================
- Coverage   85.36%   54.56%   -30.81%     
===========================================
  Files          89       88        -1     
  Lines        8445     8392       -53     
===========================================
- Hits         7209     4579     -2630     
- Misses       1236     3813     +2577     
Files Coverage Δ
src/mps/dmrg.jl 0.00% <ø> (-83.59%) ⬇️

... and 36 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mtfishman
Copy link
Member

Thanks!

@mtfishman mtfishman merged commit 9a7380f into ITensor:main Nov 3, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants