Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ITensorGaussianMPS] Fix keyword argument forwarding issue #1228

Merged
merged 2 commits into from
Nov 1, 2023

Conversation

mtfishman
Copy link
Member

Fix keyword argument forwarding issue exposed by the keyword argument refactor in #1226.

@mtfishman
Copy link
Member Author

[test ITensorGaussianMPS] [test ITensors mps]

Copy link
Contributor

github-actions bot commented Nov 1, 2023

Run ITensorGaussianMPS tests from comment trigger: succeeded ✅
https://github.com/ITensor/ITensors.jl/actions/runs/6724977636

1 similar comment
Copy link
Contributor

github-actions bot commented Nov 1, 2023

Run ITensorGaussianMPS tests from comment trigger: succeeded ✅
https://github.com/ITensor/ITensors.jl/actions/runs/6724977636

Copy link
Contributor

github-actions bot commented Nov 1, 2023

Run ITensors mps tests from comment trigger: succeeded ✅
https://github.com/ITensor/ITensors.jl/actions/runs/6724977642

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (66f5d39) 85.28% compared to head (5a6fdcc) 54.43%.

❗ Current head 5a6fdcc differs from pull request most recent head 3d2db08. Consider uploading reports for the commit 3d2db08 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1228       +/-   ##
===========================================
- Coverage   85.28%   54.43%   -30.85%     
===========================================
  Files          89       88        -1     
  Lines        8445     8392       -53     
===========================================
- Hits         7202     4568     -2634     
- Misses       1243     3824     +2581     

see 41 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mtfishman mtfishman merged commit fe84b9e into main Nov 1, 2023
7 checks passed
@mtfishman mtfishman deleted the ITensorGaussianMPS_kwarg_fix branch November 1, 2023 21:26
Copy link
Contributor

github-actions bot commented Nov 1, 2023

Run ITensors mps tests from comment trigger: succeeded ✅
https://github.com/ITensor/ITensors.jl/actions/runs/6724977642

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants