Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NDTensors] Array storage combiner contraction refactor #1237

Merged
merged 18 commits into from
Nov 4, 2023

Conversation

mtfishman
Copy link
Member

With this PR, combining and uncombining of dense and block sparse tensors using the new array storage design work on a wide range of tests. I also refactored the code into two layers, one layer that takes a tensor and unwraps the indices, and another that does the combiner contraction on either Array or BlockSparseArray. I think it is a lot more readable now, and the tensor layer is very minimal.

The main limitation is that information about the QNs is not available at the BlockSparseArray level so the autofermion code had to be disabled for now. I'm sure we can find a nice solution to that, either with a callback function storing information about the QNs or with an AbstractBlockSparseArray subtype that stores QN information.

@codecov-commenter
Copy link

codecov-commenter commented Nov 4, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (063ccbe) 85.36% compared to head (b015e96) 54.56%.
Report is 2 commits behind head on main.

❗ Current head b015e96 differs from pull request most recent head da76c3d. Consider uploading reports for the commit da76c3d to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1237       +/-   ##
===========================================
- Coverage   85.36%   54.56%   -30.81%     
===========================================
  Files          89       88        -1     
  Lines        8445     8392       -53     
===========================================
- Hits         7209     4579     -2630     
- Misses       1236     3813     +2577     
Files Coverage Δ
src/mps/dmrg.jl 0.00% <ø> (-83.59%) ⬇️

... and 36 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@mtfishman mtfishman merged commit 351770e into main Nov 4, 2023
7 checks passed
@mtfishman mtfishman deleted the NDTensors_blocksparsearray_cleanup branch November 4, 2023 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants