Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NDTensors] BlockSparseArray contract, QR, and Hermitian eigendecomposition #1247

Merged
merged 21 commits into from
Nov 17, 2023

Conversation

mtfishman
Copy link
Member

@mtfishman mtfishman commented Nov 10, 2023

This defines some more tensor and matrix algebra for BlockSparseArray, such as contraction, QR, and Hermitian eigendecomposition.

@emstoudenmire
Copy link
Collaborator

I see what you mean about the decompositions. The QR code here is very compact – much of it by line number seems to mainly be the various small helper functions, then the core code actually doing the algorithm is quite short.

@codecov-commenter
Copy link

codecov-commenter commented Nov 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9060282) 85.44% compared to head (9ae8885) 54.80%.

❗ Current head 9ae8885 differs from pull request most recent head 054e837. Consider uploading reports for the commit 054e837 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1247       +/-   ##
===========================================
- Coverage   85.44%   54.80%   -30.64%     
===========================================
  Files          89       88        -1     
  Lines        8402     8349       -53     
===========================================
- Hits         7179     4576     -2603     
- Misses       1223     3773     +2550     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mtfishman mtfishman changed the title [NDTensors] Attempting to get QN DMRG working with BlockSparseArray storage [NDTensors] BlockSparseArray QR and Hermitian eigendecomposition Nov 16, 2023
@mtfishman mtfishman changed the title [NDTensors] BlockSparseArray QR and Hermitian eigendecomposition [NDTensors] BlockSparseArray contract, QR, and Hermitian eigendecomposition Nov 16, 2023
@mtfishman mtfishman marked this pull request as ready for review November 16, 2023 21:35
mtfishman and others added 2 commits November 16, 2023 19:14
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…m:ITensor/ITensors.jl into NDTensors_blocksparsearray_tensor_algebra
@mtfishman mtfishman merged commit 408516d into main Nov 17, 2023
9 checks passed
@mtfishman mtfishman deleted the NDTensors_blocksparsearray_tensor_algebra branch November 17, 2023 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants