Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NDTensors] Remove SetParameters and replace with TypeParameterAccessors #1353

Merged
merged 23 commits into from
Mar 18, 2024

Conversation

kmp5VT
Copy link
Collaborator

@kmp5VT kmp5VT commented Mar 14, 2024

Description

In this PR I am trying to remove the SetParameters module and replace it with the TypeParameterAccessors version. The goal here is not to completely rewrite the systems which exist for TensorStorage and Tensor types because these will eventually be removed. For these objects I will try to apply a patch which minimizes the number of changes. I will also try to move ndims from NDTensors to TypeParameterAccessors. In this PR I will not try to rewrite functions with TypeParameterAccessors in the future we can try to simplify functions with the new functionality of this module

Checklist:

  • Set Parameters is removed
  • All unittests pass with TypeParameterAccessors definitions
  • ndims function is moved to TypeParameterAccessors

@codecov-commenter
Copy link

codecov-commenter commented Mar 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.78%. Comparing base (70052f1) to head (d94d8e3).

❗ Current head d94d8e3 differs from pull request most recent head 329e731. Consider uploading reports for the commit 329e731 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1353       +/-   ##
===========================================
- Coverage   84.39%   53.78%   -30.61%     
===========================================
  Files         100       99        -1     
  Lines        8581     8528       -53     
===========================================
- Hits         7242     4587     -2655     
- Misses       1339     3941     +2602     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kmp5VT
Copy link
Collaborator Author

kmp5VT commented Mar 15, 2024

I have this now working on all GPUs and CPU. I just need to look into moving ndims to TypeParameterAccessors

NDTensors/src/imports.jl Outdated Show resolved Hide resolved
@kmp5VT
Copy link
Collaborator Author

kmp5VT commented Mar 18, 2024

@mtfishman This branch should be ready now to review. Thanks!

@mtfishman
Copy link
Member

Looks good, thanks!

@mtfishman mtfishman merged commit 3e30629 into ITensor:main Mar 18, 2024
8 checks passed
@emstoudenmire
Copy link
Collaborator

Nice PR!

@kmp5VT kmp5VT deleted the kmp5/refactor/removesetparameters branch March 19, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants