-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NDTensors] Remove SetParameters and replace with TypeParameterAccessors #1353
[NDTensors] Remove SetParameters and replace with TypeParameterAccessors #1353
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1353 +/- ##
===========================================
- Coverage 84.39% 53.78% -30.61%
===========================================
Files 100 99 -1
Lines 8581 8528 -53
===========================================
- Hits 7242 4587 -2655
- Misses 1339 3941 +2602 ☔ View full report in Codecov by Sentry. |
…/ITensors.jl into kmp5/refactor/removesetparameters
I have this now working on all GPUs and CPU. I just need to look into moving |
@mtfishman This branch should be ready now to review. Thanks! |
Looks good, thanks! |
Nice PR! |
Description
In this PR I am trying to remove the
SetParameters
module and replace it with theTypeParameterAccessors
version. The goal here is not to completely rewrite the systems which exist forTensorStorage
andTensor
types because these will eventually be removed. For these objects I will try to apply a patch which minimizes the number of changes. I will also try to movendims
fromNDTensors
toTypeParameterAccessors
. In this PR I will not try to rewrite functions withTypeParameterAccessors
in the future we can try to simplify functions with the new functionality of this moduleChecklist:
TypeParameterAccessors
definitionsTypeParameterAccessors