[NDTensors] Fix issue in Tensor constructor when storage involves wrapper types
#1441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmp5VT
commented
May 14, 2024
mtfishman
reviewed
May 14, 2024
mtfishman
changed the title
Tensor constructor when storage involves wrapper types
|
Can you split off the fixes to |
kmp5VT
commented
May 14, 2024
|
Looks good, thanks. I'm going to double check that this fixes the issue I originally saw in JanReimers/ITensorMPOCompression.jl#7 once I change that over to constructing the ITensor from the storage, but otherwise this looks good to go. I see a failure in the Metal tests but maybe that is just a random failure unrelated to this PR? |
|
Ok, I checked that this fixes the issue I was seeing in JanReimers/ITensorMPOCompression.jl#7 so I'll merge once tests pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the proposed solution from issue 1438 and should make it possible now to create a copy
Tensor/ITensorfrom a view of anotherTensor/ITensor. I also fixed an additional constructor in UnallocatedArrays that should sayUnallocatedXinstead ofnewI am adding a test for that in the unittests nowFixes #1438.