[BlockSparseArrays] Fix eachindex(::BlockSparseArray) with dual axes #1479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtfishman
changed the title
mtfishman
commented
May 30, 2024
NDTensors/src/lib/BlockSparseArrays/ext/BlockSparseArraysGradedAxesExt/test/runtests.jl
Outdated
Show resolved
Hide resolved
mtfishman
commented
May 30, 2024
mtfishman
commented
May 30, 2024
NDTensors/src/lib/BlockSparseArrays/ext/BlockSparseArraysGradedAxesExt/test/runtests.jl
Show resolved
Hide resolved
|
I think this isn't a good fix since it is too hacky, I'll try overloading |
mtfishman
changed the title
|
@ogauthe in the latest commit I added a temporary fix for printing BlockSparseArray with mixed dual and non-dual axes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a temporary hack to fix
eachindex(a::BlockSparseArray)whenahas a mixture of dual and non-dual axes.This will be fixed in a better way once GradedAxes is rewritten using BlockArrays v1 but for now I'm implementing some temporary fixes for issues like this and other ones being tracked in ITensor/BlockSparseArrays.jl#2.
@ogauthe