-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NDTensors] split dual into UnitRangeDual and GradedUnitRangeDual #1529
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rebase on latest GradedAxes set GradedAxes as a Sector dependency define fusion rules for simple categories pass test for simple categories
Currently, this branche solves:
g = gradedrange([U1(1) => 2, U1(2) => 2])
@test GradedAxes.blocklengths(dual(g)) isa Vector{<:LabelledInteger} # # broken in main and in non-abelian_fusion
blocklengths(dual(gradedrange([U1(0) => 2, U1(1) => 2])[1:3])) isa Vector # broken in main and in non-abelian_fusion
r = gradedrange([U1(0) => 2, U1(1) => 2])[1:3]
a = BlockSparseArray{Float64}(r, r)
b = BlockSparseArray{Float64}(dual(r),dual(r))
@test a[:, :] isa BlockSparseArray # broken in main and in non-abelian_fusion
@test b[:, :] isa BlockSparseArray # broken in main and in non-abelian_fusion Meaning one can create and manipulate It also adds many tests, including broken ones. |
1 task
replaced by #1531 |
17 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to simplify the use of
GradedAxes.dual
, especially to be used in aBlockSparseArray
. It proposes to split theUnitRangeDual
type into two different types:UnitRangeDual{<:AbstractUnitRange} <: AbstractUnitRange
GradedUnitRangeDual{<:LabelledInteger,<:AbstractGradedUnitRange} <: AbstractGradedUnitRange
This should simplify slicing a
BlockSparseArray
with dual axes and allows to preserve labels or take their dual.This branch is built on top of #1363 and should only be merged once #1363 is completed. It does not make any change in
Sectors
.