Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ITensors] Fix broken broadcast operation on GPU #1532

Merged
merged 19 commits into from
Oct 13, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Revert changes
  • Loading branch information
kmp5VT committed Oct 7, 2024
commit 78684480ff99ef6dd34e6028ab6259459965ea95
7 changes: 1 addition & 6 deletions ext/ITensorsVectorInterfaceExt/ITensorsVectorInterfaceExt.jl
Original file line number Diff line number Diff line change
@@ -38,12 +38,7 @@ function VectorInterface.add(a::ITensor, b::ITensor, α::Number, β::Number)
return a * β + b * α
end
function VectorInterface.add!(a::ITensor, b::ITensor, α::Number, β::Number)
## TODO Coding it this way skips code which fails on GPU in broadcast.jl
## Not a permanant fix, just here until the broadcast function can be
## updated
a .*= β
a .+= b .* α
# a .= a .* β .+ b .* α
a .= a .* β .+ b .* α
return a
end
function VectorInterface.add!!(a::ITensor, b::ITensor, α::Number, β::Number)