-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GradedAxes] Introduce LabelledUnitRangeDual #1571
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ogauthe
force-pushed
the
LabelledUnitRangeDual
branch
from
November 6, 2024 22:21
a352498
to
8e988c0
Compare
mtfishman
changed the title
[NDTensors][GradedAxes] introduce LabelledUnitRangeDual
[GradedAxes] introduce LabelledUnitRangeDual
Nov 7, 2024
mtfishman
reviewed
Nov 7, 2024
mtfishman
changed the title
[GradedAxes] introduce LabelledUnitRangeDual
[GradedAxes] Introduce LabelledUnitRangeDual
Nov 7, 2024
mtfishman
reviewed
Nov 7, 2024
Looks good to me, ready to merge from your end? |
With this PR, we now have an error with label(dual(labelled(1:1, "x"))) ERROR: MethodError: no method matching dual(::String)
Closest candidates are:
dual(::NDTensors.SymmetrySectors.Ising)
@ NDTensors ~/Documents/itensor/ITensors.jl/NDTensors/src/lib/SymmetrySectors/src/sector_definitions/ising.jl:24
dual(::NDTensors.SymmetrySectors.Fib)
@ NDTensors ~/Documents/itensor/ITensors.jl/NDTensors/src/lib/SymmetrySectors/src/sector_definitions/fib.jl:24
dual(::NDTensors.SymmetrySectors.TrivialSector)
@ NDTensors ~/Documents/itensor/ITensors.jl/NDTensors/src/lib/SymmetrySectors/src/sector_definitions/trivial.jl:15
...
Stacktrace:
[1] label(a::LabelledUnitRangeDual{LabelledInteger{Int64, String}, LabelledUnitRange{Int64, UnitRange{Int64}, String}})
@ NDTensors.GradedAxes ~/Documents/itensor/ITensors.jl/NDTensors/src/lib/GradedAxes/src/labelledunitrangedual.jl:16
[2] top-level scope
@ REPL[12]:1 Maybe we should default |
That would make sense as a definition, we do that as a default definition for unit ranges anyway. |
mtfishman
reviewed
Nov 7, 2024
mtfishman
reviewed
Nov 7, 2024
Ready to merge! |
Great, thanks. I'll merge once tests pass. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix cases where dual information is lost while slicing a
BlockSparseArray
. There are 2 cases:GradedUnitRangeDual
with aBlock
now produces a (non-blocked)LabelledUnitRangeDual
, which preserves dual informationGradedUnitRangeDual
with a vector ofBlock
orBlockIndexRange
produces aBlockVector
whose only axis is aGradedUnitRangeDual
. This is needed in views ofBlockSparseArray
.