[NDTensors] Introduce NestedPermutedDimsArrays
submodule
#1589
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces a
NestedPermutedDimsArrays
module that defines aNestedPermutedDimsArray
type, which is like Base.PermutedDimsArray but is singly nested, i.e. it is a lazily permuted array where the elements are also lazily permuted.This is meant to serve as the new output type of
blocks(::PermutedDimsArray)
inBlockSparseArrays
, i.e.blocks(a::PermutedDimsArray) = NestedPermutedDimsArray(blocks(parent(a)), perm(a))
, as an alternative to the current design based on SparsePermutedDimsArrayBlocks. That will make thePermutedDimsArray
wrapper more in line with the design of theAdjoint
andTranspose
wrappers as of #1580. However, in order for that to work, we will also have to add support forNestedPermutedDimsArrays
inSparseArrayInterface
, which will be handled in a future PR.@lkdvos
Note that something similar could be achieved by composing a
PermutedDimsArray
with aMappedArray
where the map (and inverse map) itself constructs aPermutedDimsArray
, and in fact that was an earlier design I used inBlockSparseArrays
. Maybe we can consider that in the future, though dealing with nested wrappers might be a bit tricky to deal with inSparseArrayInterface
right now, so this approach feels simpler for now.