Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

icinga-stack: extraEnvVars value for icinga2/icingadb #37

Merged

Conversation

loicwinkopp
Copy link
Contributor

Value to add extra environment variables in icinga2 container, useful to fill variables like PGHOST, PGPORT, PGDATABASE, PGUSER, PGPASSWORD, etc.

Copy link

cla-bot bot commented Jan 25, 2024

Thank you for your pull request. Before we can look at it, you'll need to sign a Contributor License Agreement (CLA).

Please follow instructions at https://icinga.com/company/contributor-agreement to sign the CLA.

After that, please reply here with a comment and we'll verify.

Contributors that have not signed yet: @loicwinkopp

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Please contact us if you think this is the case.

  • If you signed the CLA as a corporation, your GitHub username may not have been submitted to us. Please reach out to the responsible person in your organization.

@loicwinkopp
Copy link
Contributor Author

Done!

@lippserd
Copy link
Member

@cla-bot check

@cla-bot cla-bot bot added the cla/signed CLA is signed by all contributors of a PR label Jan 25, 2024
@martialblog
Copy link
Member

@mocdaniel looks alright to me. In fact, might be good to add this to other charts as well?

@loicwinkopp
Copy link
Contributor Author

@martialblog @mocdaniel I added it for icingadb (seemed more relevant to me than for icinga web) and added tests

Copy link
Collaborator

@mocdaniel mocdaniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contribution @loicwinkopp

@mocdaniel mocdaniel changed the title icinga-stack: extraEnvVars value for icinga2 icinga-stack: extraEnvVars value for icinga2/icingadb Feb 17, 2024
@mocdaniel mocdaniel merged commit 8216931 into Icinga:main Feb 17, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla/signed CLA is signed by all contributors of a PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants