This repository has been archived by the owner on Nov 6, 2024. It is now read-only.
Hiera configures the primary listen interface, no magic ifname lookup anymore #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… anymore
Parallels as Vagrant provider ignores "predictable interface names" coming with CentOS7.
The VirtualBox provider from Vagrant itself enables this as default with > 1.8.3.
Therefore we have `enp0s8` vs `eth1`.
Doesn't work reliably, and therefore `hierdata/node/{::fqdn}.yaml` defines the hostonly
primary listen interface where needed. This is possible with interpolation in Hiera 5 by
doing a reverse lookup() call.
fixes #141
|
@nbuchwitz please test it as well. I still need to test whether Parallels now works, or not. |
|
@dnsmichi LGTM 👍 |
|
Tested with Fedora 27, VirtualBox 5.2.8 & Vagrant 2.0.2 |
|
Thanks. Parallels works too. It is always funny to bring |
|
macOS High Sierra, Vagrant 2.0.1, VirtualBox 5.1.30r118389, Parallels version 13.2.0 (43213) |
pull bot
pushed a commit
to Mattlk13/icinga-vagrant
that referenced
this pull request
Jun 14, 2019
e2e1d02a Bump to version 2.3.0 67ad3297 Add support for Filebeat 6 (Icinga#141) f38bb372 Support for hash.random (Icinga#142) 9b4a45ed Update archive version_requirement (Icinga#138) 6e8ff5b2 Increment version to 2.2.0 c3e32e65 Release tagged builds to the forge automatically f5446a5f Don't skip installing development packages b02468bd Don't install rake explicitly the the travis setup 35bf62b2 Install rake in travis directly 6df1a5f3 Explicitly add rake to the bundle 707a26b0 Follow the PDK format for metadata.json 4b1628f4 Follow PDK format for non-test files 81579d16 Rework all tests to match PDK format c82dfafa Style fixes in ruby files 7e9ee6ed Cleanup lint for better linting 7c0bd56c Add support for pipeline configuration in prospectors (Icinga#134) 638dc25e Wrong regex for windows, doesn't accept . in URL (Icinga#135) c0749a24 remove duplicate entry for disable_config_test (Icinga#133) 7a9dd2d7 Upgrade to 2.1.0 cae9db2d Fix test's lint bb392435 Make configuration directory/file ownership configurable 4603793f Add additional tests f24a6fc1 Processors should be passed as a hash, not array 5f89f717 Chagne beat_name configuration parameter to name (Fixes Icinga#126) 367d5339 Fix typo in changelog 85987da0 Release version 2.0.0 d41cde9c Fixes Icinga#124 - Use correct url for 32 bit windows (Icinga#125) 01e36b74 Update apt dependency (Icinga#123) baf7c7bf Drop support for Puppet 3 and Filebeat <5 (Icinga#118) ee343811 Release 1.0 acf48c80 Fix testing environment variables 59d50468 Add loadbalance for ES in filebeat5.yml.erb (Icinga#119) 6683ba5e Fix Logstash SSL template (Icinga#121) 970b35a5 Note breaking changes that will follow the next release f802ff45 Update changelog and note puppet 5 support ec768ede filebeat 5 ssl support (Icinga#117) 54a6fca6 Fix style typo in changelog d288ea60 Increment version number to 0.12.0 a5e44f8e Update changelog to reflect recent features 3ede14a4 Update puppet dependency to 3.5+ 9e5cc2ce Merge pull request Icinga#115 from MiamiOH/master b7e008e5 Typo fix; Also use install_dir in config validate_cmd 5e3f86be Merge pull request Icinga#114 from MiamiOH/master 57336544 Some windows install clean up 30d58b2e Merge pull request Icinga#113 from MiamiOH/master 2a9ad254 Fix filebeat_spec a9c86360 Pin apt in fixtures to continue puppet 3 support 17a33d1e Clean up temp file on Windows install 1a286627 Use package_ensure for the same thing on windows and linux 7c1b1fda Fixes Icinga#109 - Windows update support 0912b163 install locales on ubuntu-16.04 nodeset (Icinga#111) 758656ed add optional repo_priority parameter (Icinga#110) 00e0b723 Increment version to 0.11.2 0fc9c46a support kafka codec.format option (Icinga#106) 5b6d42d4 Explicitly support newer versions of the puppetlabs/powershell module c48422cc The `add_locale` processor doesn't require parameters (Icinga#104) 5f8adb23 Don't check boolean value of certain config parameters e818c827 processor: Checking for the drop_event processor instead of the non-existent drop_field (Icinga#101) f4b5699e Properly allow failures for puppet 3.8.7 72cd00d5 Fix yaml syntax aa883e96 Allow failures when testing puppet 3.x 89e30ef2 Increment version number to 0.11.1 0d1d5a40 Test with a specific version of puppet 3.8 bdd9c981 Restore puppet 3 compatibility (for now) 607c62aa Increment version to v0.11.0 56bfa125 Support for round_robin algo and group_events (Icinga#100) d2a2b524 Update changelog with fix for Icinga#63 47a608b5 Check for nil instead of undef in max_procs da9c06bf Update Changelog e904898b Conditional pipeline in output.elasticsearch (Icinga#98) ea395267 Update chaining to match latest style guide f542ee28 Merge branch 'master' of github.com:pcfens/puppet-filebeat e17b449c Index conditional match in output elasticsearch (Icinga#97) 403a6692 Update README and CHANGELOG with breaking change information c064eac3 Don't verify processor files (they don't have prospectors so they always fail) 3e408402 Move the default registry file ea30d5b9 Pin version of rubocop gem 19a1ca75 Remove trailing whitespace in spec test 228b9b17 Fix style in spec test 3b81c8a8 Style changes to metadata.json and fixes 696e37b5 Create a method for removing filebeat using puppet 38ffce20 Add proxy server support to download files (Windows) (Icinga#90) 1407b090 Reworking the processor implementation. (Icinga#85) 8499ee8c Increment version number to v0.10.4 3ae5d968 Add support for output.console ede4c4a3 Conform to strict_variables 8afca8dd Increment version number to v0.10.3 c44c0df2 Exempt facter confine line from the breaking rubocop test 92d5f513 Revert change to confine in filebeat_version dd1c3535 Make an attempt at supporting processors in puppet < 4.x 93ef7e1f Allow http links for downloading filebeat for windows (Icinga#82) adc80458 Remove Ruby 1.9.3/Puppet 3.8 travis tests e858f2da Add a check to see if processors.params is emtpy before using it. 4cb659d0 Increment version to v0.10.2 53254830 add close_older and force_close_files within prospector v5 (Icinga#77) 1aa78c0d Update rubocopy to match voxpupuli's latest modulesync 2482954b Increment version number e9f1dd05 Assume that windows paths will have spaces in them (Fixes Icinga#75) a07192ad support harvesting symlinks (Icinga#74) ca733c51 Fix typo in changelog diff links 930d8a17 Merge in changes from a previous release dea9678f Increment version number to v0.10.0 4917f249 Add JSON decoding to the changelog 7fb3d094 Add support for json decoding (filebeat >= 5.0) (Icinga#72) 3f9a7142 Increment version to 0.9.2 abf7f99a Add close and clean harvesting (Icinga#70) 50409d58 Increment version number to 0.9.1 b5532281 Fixing yaml spacing and README tutorials for params. 77b4a4f5 Increment version to 0.9.0 1b185044 Don't install development packages when testing 7b86bd16 Lint fixes 6287d6d6 Clean up tests some more e5ebb2e6 Improve testing and attempt to meet voxpupuli's style standards a38244c3 Update changelog b6b8386f Add a note about the registry_path to the readme 25054a2f Update download URL for windows to latest b6365393 Align params.pp file a6d371ea Update the changelog to reflect changes over last few days 194158f8 Validate config files before restarting services 61cbcce7 All filebeat templates should include the major version number in them a12f7eda Fix a regression in filebeat_version that caused warnings before filebeat was installed 1b6b4ef2 Fix the filebeat_version fact in windows b0674fbc Add Support for Filebeat Processors 2d3d2402 Merge pull request Icinga#68 from plarivee/add_tags_to_prospector 077be4a0 Adding support for tags in prospector 1404171e Increment version number d513528d Update windows URL again 3e9e117a Merge pull request Icinga#65 from elconas/fix_broken_max_procs 3a952d38 Fix error when max_procs is empty git-subtree-dir: modules/filebeat git-subtree-split: e2e1d02a51cfeb7ae880e08b21267fca95183fc9
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parallels as Vagrant provider ignores "predictable interface names" coming with CentOS7.
The VirtualBox provider from Vagrant itself enables this as default with > 1.8.3.
Therefore we have
enp0s8vseth1.Doesn't work reliably, and therefore
hierdata/node/{::fqdn}.yamldefines the hostonlyprimary listen interface where needed. This is possible with interpolation in Hiera 5 by
doing a reverse lookup() call.
fixes #141