-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add redundancy group detail view #1079
Conversation
bb57bd1
to
f0587fd
Compare
eefd449
to
e82398e
Compare
4be5a02
to
bfb4c51
Compare
30610c2
to
cc17f79
Compare
9bee89a
to
f6f6316
Compare
RedundancyGroupSummary: Add columns for `(un)acknowledged` count
3675d71
to
7332d2c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code review done, testing now
bc79ebc
to
dc09970
Compare
46f7097
to
e459865
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
- Use Translation trait's translate() method - Add sort columns to DependencyNode
ObjectHeader
- Add type hint for $state with @Property tag instead
RedundancygroupController: Add class property for group summary RedundancygroupController: Apply missing restrictions in `fetchNodes()` method rg: Use $this->httpNotFound instead rg: remove superfluous searchbar param
…vices - Add missing relation `state.last_comment` for detailed view mode
b6ab15c
to
3567a40
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM²!
resolves #1056