Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VolatileStateResults: Properly apply state changes in case of DependecyNode #1093

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

sukhwinder33445
Copy link
Contributor

No description provided.

@cla-bot cla-bot bot added the cla/signed CLA is signed by all contributors of a PR label Nov 18, 2024
@sukhwinder33445 sukhwinder33445 force-pushed the fix/volatileState-results-for-dependency-node branch from 890c146 to 63d9e1b Compare November 18, 2024 16:20
@sukhwinder33445 sukhwinder33445 self-assigned this Nov 18, 2024
@sukhwinder33445 sukhwinder33445 force-pushed the fix/volatileState-results-for-dependency-node branch 2 times, most recently from 4fd5c4f to e5c0925 Compare November 19, 2024 09:15
Copy link
Member

@nilmerg nilmerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why private const and function?

library/Icingadb/Redis/VolatileStateResults.php Outdated Show resolved Hide resolved
@sukhwinder33445 sukhwinder33445 force-pushed the fix/volatileState-results-for-dependency-node branch 4 times, most recently from 8b0a944 to a2b6335 Compare November 19, 2024 15:22
…cyNode

- Use host behaviors for sevice hosts. Previously, the service behaviors was used.
@sukhwinder33445 sukhwinder33445 force-pushed the fix/volatileState-results-for-dependency-node branch from a2b6335 to a475dbf Compare November 19, 2024 15:37
@nilmerg nilmerg merged commit 2642030 into dependencies Nov 19, 2024
22 checks passed
@nilmerg nilmerg deleted the fix/volatileState-results-for-dependency-node branch November 19, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla/signed CLA is signed by all contributors of a PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants