Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect assignment of class handled to the service badges in service grid. #452

Merged
merged 1 commit into from
Nov 12, 2021
Merged

Fix incorrect assignment of class handled to the service badges in service grid. #452

merged 1 commit into from
Nov 12, 2021

Conversation

raviks789
Copy link
Contributor

fix #451

@cla-bot cla-bot bot added the cla/signed CLA is signed by all contributors of a PR label Nov 12, 2021
@nilmerg nilmerg added bug Something isn't working area/view Affects an entire view labels Nov 12, 2021
@nilmerg
Copy link
Member

nilmerg commented Nov 12, 2021

There's actually something else wrong: Behaviors like BoolCast don't run for aliased columns. But that's something for later in a separate issue.

@nilmerg nilmerg merged commit 02bf383 into master Nov 12, 2021
@nilmerg nilmerg deleted the fix/servicegrid-service-badges branch November 12, 2021 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nilmerg nilmerg nilmerg approved these changes

Assignees

@raviks789 raviks789

Labels
area/view Affects an entire view bug Something isn't working cla/signed CLA is signed by all contributors of a PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

All services in service grid have handled problem badges.
2 participants
@raviks789 @nilmerg