Optimize loading media item details (#365)

* fix(backend): incorrect average rating being displayed * feat(frontend): load media specifics in a different query * refactor(frontend): change query names * refactor(frontend): move image data to secondary query * fix(frontend): remove allow features * build(backend): bump version * fix(frontend): do not wait for user media details to load
IgnisDa · Sep 25, 2023 · 389ab50 · 389ab50
1 parent edbfc29
commit 389ab50
Show file tree

Hide file tree

Showing 8 changed files with 262 additions and 184 deletions.
diff --git a/Cargo.lock b/Cargo.lock
diff --git a/apps/backend/Cargo.toml b/apps/backend/Cargo.toml
@@ -1,6 +1,6 @@
 [package]
 name = "ryot"
-version = "2.18.5"
+version = "2.18.6"
 edition = "2021"
 repository = "https://github.com/IgnisDa/ryot"
 license = "GPL-V3"

diff --git a/apps/backend/src/miscellaneous/resolver.rs b/apps/backend/src/miscellaneous/resolver.rs
@@ -1695,10 +1695,13 @@ impl MiscellaneousService {
         let average_rating = if reviews.is_empty() {
             None
         } else {
-            Some(
-                reviews.iter().flat_map(|r| r.rating).sum::<Decimal>()
-                    / Decimal::from(reviews.len()),
-            )
+            let total_rating = reviews.iter().flat_map(|r| r.rating).collect_vec();
+            let sum = total_rating.iter().sum::<Decimal>();
+            if sum == dec!(0) {
+                None
+            } else {
+                Some(sum / Decimal::from(total_rating.iter().len()))
+            }
         };
 
         Ok(UserMediaDetails {