This repository has been archived by the owner on Nov 25, 2022. It is now read-only.
Adds Postgres Manifests and removes Postgres Helm Chart dependency #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgwerner
suggested changes
Aug 2, 2021
| @@ -134,8 +134,11 @@ spec: | |||
| configMapKeyRef: | |||
| name: hub-illumidesk-cm | |||
| key: POSTGRES_NBGRADER_USER | |||
| - name: POSTGRES_NBGRADER_PASSWORD | |||
| value: {{ .Values.graderSetupService.postgresNBGraderPassword | default "illumidesk" }} | |||
| - name: NBGRADER_PASSWORD | |||
There was a problem hiding this comment.
Our graderservice source code only understands POSTGRES_NBGRADER_PASSWORD.
| JUPYTERHUB_API_TOKEN: {{ .Values.illumideskSettings.jupyterhubAPIToken | default "" | b64enc | quote }} | ||
| JUPYTERHUB_CRYPT_KEY: {{ .Values.illumideskSettings.jupyterhubCryptKey | default "" | b64enc | quote }} | ||
| POSTGRES_JUPYTERHUB_PASSWORD: {{ .Values.illumideskSettings.postgresHubPassword | default "postgres" | quote}} | ||
| NBGRADER_PASSWORD: {{ .Values.illumideskSettings.postgresGraderPassword | default "postgres" | quote}} |
There was a problem hiding this comment.
For consistency, we should change this value to POSTGRES_NBGRADER_PASSWORD in all locations (secrets and cm's).
| resources: | ||
| requests: | ||
| cpu: 100m | ||
| memory: 100Mi |
There was a problem hiding this comment.
Remove requests values and set limits to have an upper bound limit. We should also surface these settings in our values.yaml and update the README.md with these options.
| valueFrom: | ||
| secretKeyRef: | ||
| name: hub-illumidesk-secret | ||
| key: NBGRADER_PASSWORD |
There was a problem hiding this comment.
Change to POSTGRES_NBGRADER_PASSWORD.
|
Cannot complete grader e2e test as this image does not have grader console tab in grader container |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #44
mostly closes ##53 as it creates the appropriate secrets so secret values can be passed as envar references. This works for every secret value except
POSTGRES_NBGRADER_PASSWORD